Bug fix for chunked array support in ccpp_prebuild #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… host model variable to trigger chunked array logic
climbfuji
requested review from
grantfirl,
gold2718 and
mkavulich
as code owners
climbfuji
added
ccpp_prebuild
gold2718
approved these changes
Mar 1, 2024
Yes, it works in that case, too. Thanks for the quick review! |
|
@grantfirl UFS testing for this PR is complete. Can you add your final review please and merge if ok? Thanks! |
|
Good morning, @grantfirl . Testing is complete on UFS-WM PR #2164. Can you please merge this PR for us? |
grantfirl
approved these changes
Mar 11, 2024
grantfirl
deleted the
bugfix/ccpp_prebuild_chunked_array_support_20240228
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small bug fix required to use chunked arrays and retain backward compatibility with blocked data structures in
ccpp_prebuild.pyThis PR is a small bug fix in order to provide backward compatibility with blocked data structures. Specifically, we need to check if the host model variable is a contiguous array (it's horizontal dimension is
CCPP_HORIZONTAL_DIMENSION) or part of a blocked data structure (it's horizontal dimension isCCPP_HORIZONTAL_LOOP_EXTENT).User interface changes?: No
Resolves #539
Testing:
- test removed: none
- unit tests: capgen tests in
testall pass; prebuild tests intest_prebuildall pass- system tests: doctests in
testal pass- manual testing: tested extensively in my (yet to be created) PRs that convert all UFS DDTs from blocked data structures to chunked arrays
Dependencies/associated PRs:
This is part of a set of (independent) PRs: