Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download climatological aerosol data and fix HR3 nml typo #465

Merged
merged 2 commits into from
May 21, 2024

Conversation

grantfirl
Copy link
Collaborator

This PR adds a script in the /contrib directory to download the climatological aerosol data used when the first digit of iaer == 1. It also fixes a typo in the HR3 namelist name and adds iaer=1011 for testing HR3 (there may be other namelist changes forthcoming from @mzhangw )

Note, the script assumes that scm/data/physics_input_data directory already exists, so this should be used after the ./get_all_static_data.sh script.

Copy link
Collaborator

@dustinswales dustinswales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for doing this.
However, I wonder if we should just merge the thompson data script and this new aerosol dat fetching script into the get_all_ script?

@grantfirl
Copy link
Collaborator Author

grantfirl commented May 1, 2024 via email

@mzhangw
Copy link
Collaborator

mzhangw commented May 2, 2024

Thanks Grant. I tested the data using TWPICE case with HR3 suite and both iaer = 1011 and 5111. It works well.
Screenshot 2024-05-02 at 10 38 43 AM

@grantfirl grantfirl merged commit 1dd3d88 into NCAR:main May 21, 2024
17 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants