NML changes for HRRR_gf and GFS_v17_p8_ugwpv1 #500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th non-conforming COMBLE case DEPHY file
…rcingT to be true and surfaceforcinglsm to be true - ingests LSM data and a forcing surface T
…ts (with new DEPHY-format processed_case_input files)
dustinswales
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
@grantfirl Looks good to me.
Post-release we need to come up with a way to compare the SCM namelists with their UFS counterparts.
This should be easy to do and help us keep our configurations in the SCM consistent with the UFS.
There was a problem hiding this comment.
FYI. When I added this nml, I followed the coupled simulation, https://github.com/ufs-community/ufs-weather-model/blob/develop/tests/rt.conf#L29, which is what I thought was the HR4 target, not the control_p8_ugwpv1 test.
Hence the differences here are not isolated to recent GWD updates.
|
Superceded by #502 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contains namelist fixes for HRRR_gf to match what is used in the UFS RT hrrr_gf_debug
contains namelist fixes for GFS_v17_p8_ugwpv1 to match what is used in the UFS RT control_p8_ugwpv1
-- differences: do_ca is set to F in the SCM, do_gwd_opt_psl is set to T in the SCM
adds vegtype_frac and soiltype_frac to UFS_case_gen.py and SCM input files (not tested fully since there isn't any UFS data to test this with that we could readily find, although it correctly output the new variables in the DEPHY file and the SCM tries to read them in, they're just set to missing values and therefore not used for initialization in the SCM).
Note: This PR is stacked on the dephy_conversion branch, so #496 should be merged first