Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdatmus_z2tdp #78

Closed
wants to merge 19 commits into from
Closed

stdatmus_z2tdp #78

wants to merge 19 commits into from

Conversation

cyschneck
Copy link
Contributor

@cyschneck cyschneck commented Jul 12, 2024 •
edited
Loading

PR Summary

Calculates the corresponding temperature, density, and pressure based on the 1976 U.S. standard atmosphere, given the height via Python Package ambiance

Includes:

Related Tickets & Documents

Closes #74

PR Checklist

General

  • PR includes a summary of changes
  • Link relevant issues, make one if none exist

@cyschneck cyschneck added ncl Related to ncl specific content python entry Python-first content that do not require any knowledge of or references to NCL ncl receipt Receipt files are small files with little to no narrative content ncl entry NCL entries are pages that explain specifically how to achieve something that was possible in NCL labels Jul 12, 2024
@cyschneck cyschneck self-assigned this Jul 12, 2024
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 12, 2024 •
edited
Loading

Meowdy! See your PR preview:
🔍 Git commit SHA: a41d581
✅ Deployment Preview URL: https://NCAR.github.io/geocat-applications/_preview/78

@cyschneck cyschneck marked this pull request as ready for review July 23, 2024 20:16
jukent
jukent approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@jukent jukent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kafitzgerald
kafitzgerald reviewed Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@kafitzgerald kafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had a chance to fully look this over, but I think there are some design decisions in here we should discuss / think more about before merging.

anissa111
anissa111 requested changes Jul 24, 2024
View reviewed changes
Copy link
Member

@anissa111 anissa111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting a hold on this real quick because there's some points I need addressed before this gets merged, will update with additional info after meeting

@anissa111 anissa111 removed the request for review from andy-theia July 24, 2024 16:48
@cyschneck cyschneck marked this pull request as draft July 24, 2024 20:58
@cyschneck cyschneck removed the python entry Python-first content that do not require any knowledge of or references to NCL label Jul 31, 2024
@cyschneck cyschneck closed this Aug 27, 2024
github-actions bot pushed a commit that referenced this pull request Aug 27, 2024
@cyschneck @github-actions
Delete preview for pull request #78
ec406aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kafitzgerald kafitzgerald kafitzgerald left review comments

@anissa111 anissa111 anissa111 requested changes

@jukent jukent jukent approved these changes

Assignees

@cyschneck cyschneck

Labels
ncl entry NCL entries are pages that explain specifically how to achieve something that was possible in NCL ncl receipt Receipt files are small files with little to no narrative content ncl Related to ncl specific content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Entries for standard atmosphere calculations - stdatmus_z2tdp
4 participants
@cyschneck @kafitzgerald @anissa111 @jukent