Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lake_option to hydro_namelist, reservoirs to their own new namelist #725

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add lake_option to hydro_namelist, reservoirs to their own new namelist #725

wants to merge 5 commits into from

Commits on Nov 6, 2024

  1. Add lake_opt to namelist, reservoirs to own nlist 

    * Add `lake_option` (integer) to &hydro_nlist:
  0 [lakes off], 1 [level pool], or 2 [passthrough], or 3 [reservoir DA]

  - turning lakes off (lake_option=0) will disable lakes even if
    route_lake_f is supplied, or outlake is turned on.

  - Reservoir DA will not be used unless lake_option=3, even if all
    other required namelist options are present

* Reservoir options have been moved from &hydro_nlist to
  &reservoir_nlist

   - This will make it easier to isolate / compose namelist files

   - If lake_option is not equal to 3, &reservoir_nlist won't be read,
     meaning it can be completely removed for applications that don't
     need it
    @rcabell @scrasmussen
    rcabell authored and scrasmussen committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    eec3844 View commit details
    Browse the repository at this point in the history

  2. Update testing namelists

    @rcabell @scrasmussen
    rcabell authored and scrasmussen committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    2493f74 View commit details
    Browse the repository at this point in the history

  3. Reset lake_opt from 3 to 1 after setting DA flag

    @rcabell @scrasmussen
    rcabell authored and scrasmussen committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    1596ecc View commit details
    Browse the repository at this point in the history

  4. Fixing if statement logic

    @scrasmussen
    scrasmussen committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    dc93478 View commit details
    Browse the repository at this point in the history

  5. Use reasonable lake_option default when not specified

    @rcabell
    rcabell committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    74e4902 View commit details
    Browse the repository at this point in the history