Fixup: Use Object.assign when initializing with options

NCEAS · Sep 17, 2024 · cb86e12 · cb86e12
1 parent f083322
commit cb86e12
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/src/js/views/maps/LayerDetailsView.js b/src/js/views/maps/LayerDetailsView.js
@@ -156,9 +156,7 @@ define([
       initialize(options) {
         // Get all the options and apply them to this view
         if (typeof options === "object") {
-          Object.entries(options).forEach(([key, value]) => {
-            this[key] = value;
-          });
+          Object.assign(this, options);
         }
       },
 

diff --git a/src/js/views/maps/LayerItemView.js b/src/js/views/maps/LayerItemView.js
@@ -113,9 +113,7 @@ define([
       initialize(options) {
         // Get all the options and apply them to this view
         if (typeof options === "object") {
-          Object.entries(options).forEach(([key, value]) => {
-            this[key] = value;
-          });
+          Object.assign(this, options);
         }
       },