Skip to content
This repository has been archived by the owner on Jul 8, 2020. It is now read-only.

V3.4.x #2

Open
wants to merge 10,000 commits into
base: trunk
Choose a base branch
from
Open

V3.4.x #2

wants to merge 10,000 commits into from

Conversation

jessiejuachon
Copy link

angular bug - version incompatible

Vinaylonushte and others added 30 commits September 8, 2016 11:54
…es. So that it will work with unique specimen label per CP setting enabled.
Following changes:
1. Only super admin can update participant using BO
2. Added participant system identifier column in BO
3. This feature is only available through backend api
… type

This issue was introduced during institute admin implementation. We have
removed the isAdmin flag and added new attribute as 'user type' which can
have value SUPER or INSTITUTE or NONE.
…rticipant and CPRs

At global level (on CP list page), there will be single Bo for below purpose:
1. Create participant and register to multiple protocols
  - User need to have permission on all protocols on which participant
    is to be register

2. Update participant and their related cprs
  - User can update participant if he has access on at least on cpr
  - User can update cpr if he has access on that cpr

3. Existing participant register to other protocols
  - User needs to have access on all protocols on which participant is to be register

4. Delete single cpr if cpe activity status set to disabled,
  - Delete participant and cpr if participant register to only one protocols
  - Delete single cpr if participant register to multiple protocols
  - User needs to have delete permission on that cpr

5. Delete participant, and its cpr/cprs if participant activity status set disabled
  - User need to have delete permission on participant's registered protocols

6. Participant look up based on below fields:
  - CP short title
  - Site, MRN
  - UID
  - MPI
… shipment report query setting to default shipment report query.
…ough UI and/or BO.

Also on order add/edit page filtered the expired DPs to show only allowed DPs in drop down.
- Written widget for sites, which initially loads 100 sites.
- If there are more sites, then it will load based on search string.
- Used this widget in OS to load sites.
…ge is made so that query will work on oracle db.
…p to match with the present in DB

  -Cause: Public_id in database "receive_quality" and in pv-manager map "received_quality" (not matching with database value). Hence its not loading pvs.
…p to match with the present in DB

  -Cause: Public_id in database "receive_quality" and in pv-manager map "received_quality" (not matching with database value). Hence its not loading pvs.
…property to datepicker directive, by default its false.

By passing true we explicitly set it as true.
…property to datepicker directive, by default its false.

By passing true we explicitly set it as true.
… on serach in dropdown according to type title.
… on serach in dropdown according to type title.
…rategies

and wiring of specimen creation UI to auto allocate positions based on
strategy chosen for CP

Details:

1. UI to specify container allocation strategy to use for CP

2. Auto allocation strategies - least empty and recently used with an
   option to specify whether to store all aliquots in same box or not

3. Broken bulk aliquots creation UI into 2 steps -
   3.1: Specify aliquot requirements like count, quantity etc
   3.2: Review or assign containers based on aliquots' CP

4. An internal scheduled job to cleanup auto allocated positions
   that are not used and expired.
- Added lineage field in specimen print rule csv file.
  > *      : To print all specimen's labels.
  > New    : To print primary specimen's labels only.
  > Derived: To print derived specimen's labels only.
  > Aliquot: To print aliquot specimen's labels only.

  - Made changes in such a way, that if lineage column is not specified in print rule csv file,
    then also it will print labels for all specimens.
- Added lineage field in specimen print rule csv file.
  > *      : To print all specimen's labels.
  > New    : To print primary specimen's labels only.
  > Derived: To print derived specimen's labels only.
  > Aliquot: To print aliquot specimen's labels only.

  - Made changes in such a way, that if lineage column is not specified in print rule csv file,
    then also it will print labels for all specimens.
…y pool specimens.

For example: Suppose primary specimen is already collected by collecting one pool specimen out of two (specified in sr). Now by using API can able to collect second missed pool specimen as well individually.
…y pool specimens.

For example: Suppose primary specimen is already collected by collecting one pool specimen out of two (specified in sr). Now by using API can able to collect second missed pool specimen as well individually.
Changes on following pages
1. Custom form association
2. Register participant to another protocol
Changes on following pages
1. Custom form association
2. Register participant to another protocol
Following changes:
1. Appended concept code in bracket to pv values
2. Allowed user to search pv using concept code
vinayakapawar and others added 30 commits January 8, 2017 10:52
This was because of recent change done to show only non-system
forms on UI.

Fixes:
1. Updated list forms query condition to retrieve either unused or
non-system forms when user requests for list of non-system forms.
Unused forms fall in non-system forms category.

2. Updated forms count API to take into consideration whether
user wants to count system or non-system forms.
directory for storing consent documents. Fixed the API to create
all non-existing directories specified in upload directory setting.

The default consent directory is: $OS_DATA_DIR/participant-consents
before associating with registration records. This will avoid
transient object error that crops up when the session is auto
flushed because of queries executed to ensure business constraints
are satisfied.
step registration. This ensures users can view matched participant records but
cannot attempt to add pre-registered participants to CP.
constraint or similar errors are encountered, the Hibernate session
used for interacting with database becomes unusable. It can't be
used for further interactions with database. This causes importer
to fail for all rows from point of database error.

Fix: Added guard in importer task to ensure we start with clean
Hibernate session for every input record to be imported into
database.
other APIs to resolve specimen records, doesn't use event objects
to wrap input and output including exception. As a result, the
unhandled exception handler was considering user errors raised
by resolver as system errors with no reason, which was eventually
leading to NPE.
before "error check" code block just before doing commit.
Therefore the bug. Rectified the mistake.
% value.

showLegendValuePct = true: Displays both value and percent in legends
and tooltip

showSectionValuePct = true; Displays percent value in pie/section
PLUGINS-198: Implementation of date/time formatting AQL function.

Usage: date_format(date_expr, format)

date_expr: Any valid AQL expression that yields date/time type result

format: Format of the output string and can be made up of following
format specifier tokens:

  input date/time: 18th January 2017 16:45:33

  %year4%  - four digit year e.g. 2017
  %year2%  - two digit year  e.g. 17
  %month2% - two digit month e.g. 01
  %month3% - 3 character abbreviation of month name e.g. Jan
  %month%  - Month name string e.g. January
  %month_day% - 2 digit day of month e.g. 18
  %hour%   - Hour of the day in 24 hour format 00-23 e.g. 16
  %hour12% - Hour of the day in 12 hour format 01-12 e.g. 04
  %minute% - Minute of the hour e.g. 45
  %second% - Seconds of the minute e.g. 33
  %meridian% - AM or PM e.g. PM
To start with, the hierarchy table will be empty and should be
initialised on need basis using tools API shipped with os-extras
plugin.

Added index on specimen anatomic site column to improve performance
of queries that involve filtering of specimens based on anatomic
site value.
…ings

via plugins were not displayed in settings view. It required a server
restart to make the settings visible on UI.

Refreshed in-memory map of configuration settings with newly added
settings when a plugin is initialised.
1. Fallback to system level workflow to retrieve system wide dictionary
   when CP specific dictionary is not configured.

2. Add CP UI object, already available in view scope, to context object
   that is passed to SDE for rendering dictionary based forms. This allows
   users to frame conditions based on CP settings like - do not show PPID
   text field when PPID is auto generated.
…rtment, user can specify its primary site from which he belongs.

- Added primary site field on user sign up page.
… in the institute in which user belongs, set that site as a user's primary site.
(x, null) as same. However these are not same tuples in MySQL.
As a result, when user tries to create 2 or more missed specimens
for same protocol, the unique constraint on fields (CP, Label) is
violated eventually not allowing users to create missed specimens.

Fix:
1. Made the present unique constraint run only for MySQL databases.

2. Added a function based unique index for Oracle databases that
   will enforce uniqueness only when both collection protocol and
   specimen label are non-null.
…panning

multiple rows of input CSV file were failing as the job's CSV type was always
SINGLE_ROW_PER_OBJ. This meant auto bulk import of consents, shipping,
distribution order never worked!

This bug was caused because of incorrect check that didn't consider input file's
extension while tokenising its filename.

Fixed bug by dropping extension from filename before using it for tokenising to
determine - object, operation type, and CSV type.
as a simple attribute value change. However, in reality, this means
delete container along with its children and free up space it is
occupying in parent container...

Fixed update API to invoke delete() method when status changes to
'Disabled'
sites are shown in MRN site dropdown. However when the setting is
turned on, only those sites for which users have create participant
rights are shown in MRN site dropdown.

OPSMN-3661: Ensured "Add to Another Protocol" button is not displayed
when CP list is empty or CP list contains all the CPs for which
participant is already registered.

OPSMN-3662: When site based access restriction is turned off, all
CPs that the user can register participants are considered before
deciding whether to display "Add to Another Protocol" button or not.
When the setting is turned on, CPs based on participant MRN sites
are considered.
criteria:
  - default event form definition differs from that present in database
  - users have not customised event form
put their command buttons. For example - Refresh button in case of
JHU EPIC plugin.
…s in file name.

The problem occurs for chrome browser with comma in file name.
Fix: Add file name in double quotes while adding Content-Disposition header.
1. Simplified message displayed in confirm merge participants dialog
   box. Added hyperlink to detail view of participant that would be
   deleted after merge. Added link to documentation to allow users
   understand and appreciate participant merge business.

2. Fixed the wording of the button displayed to update an existing
   OS participant with details of external source participant that is
   not yet present in local OS database.
…unlocked

fields of selected/matched participant during registration.
… collection/recevied event values are updated from BO.

Cause: At the time of updating specimen event, we were creating new event instead of getting exsting event.
…icipants DOB

The bug got introduced when we changed UI to send timestamp containing TZ
info instead of just date as part of fix for OPSMN-3290.
… query.

The change is visible in query results view, public catalog, configurable
participants and specimens list view.

(changes picked from master branch)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants