Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disclaimer to article #530

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Disclaimer to article #530

merged 2 commits into from
Jan 13, 2025

Conversation

katrinewi
Copy link
Contributor

@katrinewi katrinewi commented Jan 3, 2025

Kommer PR i ndla-frontend som skal vise frem disclaimer!

@katrinewi katrinewi requested a review from a team January 3, 2025 12:58
@katrinewi katrinewi marked this pull request as draft January 3, 2025 13:19
@katrinewi katrinewi marked this pull request as ready for review January 6, 2025 08:48
src/api/articleApi.ts Outdated Show resolved Hide resolved
@katrinewi katrinewi requested a review from Jonas-C January 6, 2025 09:12
context: Context,
): Promise<GQLTransformedDisclaimerContent> => {
if (!article.disclaimer?.disclaimer) return { content: "" };
const { content } = await transformArticle(article.disclaimer.disclaimer, context, undefined, {});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ingen transform-opts her?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeg tror ikke det trengs, uenig? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Det kommer vel litt an på hva som blir plassert inni disclaimeren, gjør det ikke? Dersom vi plutselig begynner å tillate mer komplekse komponenter der inne blir det jo veldig relevant

@katrinewi katrinewi requested a review from Jonas-C January 8, 2025 08:21

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@katrinewi katrinewi merged commit 3d4b2c6 into master Jan 13, 2025
3 checks passed
@katrinewi katrinewi deleted the disclaimer-article branch January 13, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants