-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: configurator team, label, permission&member #388
Conversation
…vhub-widgets into feature/315-admin-page
…feature/315-admin-page
…guntenaar/neardevhub-widgets into feature/315-admin-page
@Tguntenaar I tested, UI and the functionalities to edit label permissions look great! There're some bugs:
|
@ailisp Hmm that's strange I did push a fix for that exact error. I will look into it and fix it. |
@ailisp I did some testing and can reproduce your error. It seems that after a transaction is made, the getAllCommunitiesMetadata function is called 4 times total. First time it returns null, than an array with the length of 4 (old data) and than the updated array with a length of 5 (after the transaction data). However somehow the useState hook trips and the visible data on the page shows the array of 4. I've not been able to resolve this issue, any ideas? |
This might be an unsolved problem. I checked other useState usage in DevHub and they face the same problem, for example edit community page, add an addon and save. |
…feature/315-admin-page
@Tguntenaar I still get
error when trying to add |
@ailisp Hmm, I might have overwritten the preview with another version. I deployed again and it worked for me. Could you try it once more? |
@Tguntenaar I have trouble to test it as currently wallet seems having trouble to connect to RPC nodes (certainly not related to your PR) I'll try again later |
Today wallet fails due to network congestion is resolved. This problem also doesn't exist now:
Maybe it's also due to network congestion or there was fix on the gateway side |
Resolves #315
PREVIEW
comment down below if I need to add you to the moderators
Acceptance Criteria:
An "Admin" link is visible in the header navigation, visible and accessible only to DevHub admins (not community admins!)
When a DevHub admin clicks the Admin button, they see a settings page with the existing section for configuring the featured communities + a new section for configuring the label permissions
Make the UI more intuitive for label permissions so that it is clear for a moderator how they can perform the common tasks
In my last call with ori about issue #129 we discussed that I should rethink the formally known Teams page into an intuitive UI. I have made two major improvents and some minor:
We decided to simplify the task by only allowing 1 label per team. This made possible that the user can create a label and team at the same time instead of seperate and having to link them together afterwards.
The next improvement I made is removing most of the buttons for every action. Before we had a create, an edit and delete button/toggle for every members, labels, teams, permissions. Now this all abstracted away by simply creating, editing and deleting a team in one configurator.
We decided to make a clear distinction between the moderators group and other groups.
Additionally:
The moderators description (in the devhub.near contract) should be changed to:
The moderator group has permissions to edit any posts, and apply all labels including restricted ones.