initial typescript support #468

Tguntenaar · 2023-11-14T19:33:47Z

Resolves #456

I've used this TS starter from @frol to support typescript in this repo. The process is as follows:

copy all jsx files to build/src
transpile the tsx file to jsx files to build/src
replace Account Id Contract id and network with replace.js
replace exports with build.js

This way we don't have to move everything to typescript now but we can do it file by file

Tguntenaar · 2023-11-14T20:33:02Z

@frol @elliotBraem any feedback on this?

frol

Overall, looks great to me, though i feel we also need to add some watch-io script command to package.json, so during local development we don't need to manually rebuild after each edit.

replacements.mainnet.json

.gitignore

global.d.ts

package.json

scripts/build.js

scripts/dev.sh

src/devhub/components/atom/Tag.tsx

scripts/dev.sh

…out of github action

…feature/456-move-to-typescript

Tguntenaar · 2023-11-19T12:29:58Z

Overall, looks great to me, though i feel we also need to add some watch-io script command to package.json, so during local development we don't need to manually rebuild after each edit.

@frol @elliotBraem @ailisp Thank you for the review. Which package are you referring to? I used watchman since I was already familiar with it.

Let me know what you guys think!

scripts/dev.sh

src/devhub/entity/community/Tile.jsx

…e/456-move-to-typescript

Tguntenaar

This PR is ready for review again. Yesterday I had issues with the watch script that it would hot reload 8 times on changes to Tag.tsx. Today these issues seem to be gone at my end. Could you thoroughly test this?

…e/456-move-to-typescript

frol

It looks good to me, but I have not tested it locally.

@Megha-Dev-19 Could you give it a try and see if it works as expected when you edit src/devhub/components/atom/Tag.tsx? 🙏

CONTRIBUTING.md

Megha-Dev-19 · 2023-12-18T17:06:27Z

hey @frol @Tguntenaar, I just tested it locally and the changes are reflected as expected. 👍

ailisp · 2023-12-20T04:28:08Z

@Tguntenaar Can you resolve the conflict and we'll merge it!

…e/456-move-to-typescript

elliotBraem · 2024-01-03T18:19:44Z

Waiting to resolve conflicts this last time then will merge

…e/456-move-to-typescript

* initial typescript support (need to adjust github action) * fix: replace strings before bos-loader is called * remove dist * refac Tag to transpile to MainComponent * change transpiledPathPrefix to build/src * rename BaseProps to DevHubBaseProps * transpile to build/src * change REPL_DEVHUB_CONTRACT replacement back to devgovgigs.near * wip: move replacements to js script and out of dev.sh (mac only) and out of github action * lint * refac: remove include from history * refac: remove INCLUDE: and add autocomplete module * remove: unused legacy include.js * fix: deploy bos components from ./build working directory * feat: add watchman to build files on change * remove node package fb-watchman * fix: pipeline test issue caused by watchman * fix: move to watchman nodejs client * fix: instead of MainC.. use funcName after transpile * remove old comments * remove unused SIGNER_ID * added default account_id * fix: removed cause generated neardevhub-widgets * fix: buggy behaviour * change CONTRIBUTING.md * changed: use watcher instead of fb-watchman * remove fb-watch commands * added options to watch * blocked, running npm run watch from dev.sh rebuilds too often * feat: trap bos-loader and run watch parallel * update: contribution.md on the dev process * remove watchmanconfig * Update CONTRIBUTING.md zsh -> sh * update import statement * edit the CONTRIBUTING deploy preview steps * fmt

elliotBraem · 2024-01-05T00:38:31Z

scripts/dev.sh

-            ;;
-        -n|--network)
-            NETWORK_ENV="$2"
+            ACCOUNT_ID="$2"   


@Tguntenaar

Getting rid of the custom contract and network has made the following command stop working:

npm run dev:testnet -- -a devhub-dev.testnet -c bodevhub.testnet -n dev

The account should be custom because it can either be devhubtest.testnet or devhub-dev.testnet (so package.json should not hardcode the account)

Contract needs to be custom, for example when using bo's contract for announcements

Network should be custom to follow contract and account

Hey Elliot! Thank you for pointing this out. We should discuss this.

The replacement of those constants in now handled in replace.js instead.

The bos-loader only uses the the ACCOUNT_ID to deploy the widgets.

So when you want to change the account / contract / network this can be done by either editing the package.json or making use of the replacements.*.json files.

If we want npm run dev to take those arguments we will have to pass it on to the npm run watch script, which has to pass it to the npm run build, which passes it to the replace... I thought this would be less optimal.

Btw this is because the watch has to rerun the replace script for every build.

elliotBraem · 2024-01-05T00:40:03Z

package.json

    "dev": "npm run dev:mainnet",
+    "dev:mainnet": "./scripts/dev.sh -a devhub.near",
+    "dev:testnet": "./scripts/dev.sh -a devhub.testnet",


Just "dev:testnet": "./scripts/dev.sh"

elliotBraem · 2024-01-05T00:41:05Z

scripts/replace.js

@@ -3,11 +3,10 @@ import path from "path";

 const args = process.argv.slice(2);

-let NETWORK_ENV = "mainnet";
+let NETWORK_ENV = "testnet";


Is this right? I think this should maybe default to mainnet or be overriden from arguments

This reverts commit 8f28dbb.

* feat: Community Announcements Page (#567) * fix solution action * added community announcements UI * added compose field * minor css updates * use community data instead of dummy data * minor UI updates * add mentions notifications * remove unecessary code * remove hover effect * sets up for contract, adds admin check * fix: Fixed deposit error for grant_write_permissions call to social.near (#563) * add elliot and thomas to CODEOWNERS (#570) * Fix telegram string and array issue (#571) * fix solution action * fix telegram string and array issue * update telegram_handle * fix handle and URL * fix tests * prettier update * fix tests * prettier update * Bugfix/559 error flashes (#569) * fix: flash on home screen * fix: error flash on addon tabs * fix: telegram bug * test fix Tile error flash * fix: catch Tile error flash in every component it is used * remove console.log * Playwright test for input validatiojn (#577) * feature: Added input validation when creating and editing a community (#172) * feature: Added input validation when creating and editing a community * feature: Added input validation when creating and editing a community * feature: Added input validation when creating and editing a community * test: Added test for input validation * fix CI (#581) * fix the test case * Improve robustness of admin moderator tests * Clear draft changes after txn is approved (#588) * remove `onDraftStateChange` from editor * updated changes * move txn hash as props * update draft change --------- Co-authored-by: Elliot Braem <[email protected]> Co-authored-by: T guntenaar <[email protected]> Co-authored-by: Espen Simensen <[email protected]> * replacements for testnet * allow no communities found * attach 2N when creating a community * configures with updated function call * updated announcements UI (#606) Co-authored-by: Elliot Braem <[email protected]> * updates feed * working feed * show preview * fix testnet * Revert "initial typescript support (#468)" This reverts commit 8f28dbb. * Move community Github and Board widgets from devgogigs to devhub (#561) * fix solution action * added required components * remove unnecessary code * add hidden btn * update github configurator * prettier update * fix flash error issue * more improvements * prettier update * refactor code * add comment * added state for when no configurations exists * fix pagination error * handle error * fix map error * fix amount issue * updated UI * decoupled state * remove replace fn * remove title on new column --------- Co-authored-by: T guntenaar <[email protected]> * Kanban board UI enhancement (#620) * fix solution action * added required components * remove unnecessary code * add hidden btn * update github configurator * prettier update * fix flash error issue * more improvements * prettier update * refactor code * add comment * added state for when no configurations exists * fix pagination error * handle error * fix map error * fix amount issue * updated UI * decoupled state * added styling * added table view * updated UI for github * more style updates * added border to table * refactor code * cleaned UI * refactor code * added sorting mechanism * prettier update * reduce border size * remove table and few style updates * fix normalize error and suggestive UI changes * fix .map error * remove table view data * update to devhub.near * fix posts for devgovgigs.near * Points tests to devhub.near rather than devgovgigs.near (#595) * converts devgovgigs to devhub * fix: type * fix feeds * Announcements tests (#639) * added few announcements tests * hide card when no posts exists * add more tests and fix announcements UI * add feed tests * fixed UI * fix community tests * tests * format * working test * format * posts legacy --------- Co-authored-by: Megha-Dev-19 <[email protected]> Co-authored-by: T guntenaar <[email protected]> Co-authored-by: Espen Simensen <[email protected]>

initial typescript support (need to adjust github action)

e8d0e3d

Tguntenaar changed the title ~~initial typescript support (need to adjust github action)~~ initial typescript support Nov 14, 2023

Tguntenaar self-assigned this Nov 14, 2023

Tguntenaar requested a review from elliotBraem November 14, 2023 20:32

frol approved these changes Nov 14, 2023

View reviewed changes

replacements.mainnet.json Outdated Show resolved Hide resolved

.gitignore Outdated Show resolved Hide resolved

global.d.ts Outdated Show resolved Hide resolved

elliotBraem reviewed Nov 15, 2023

View reviewed changes

frol reviewed Nov 15, 2023

View reviewed changes

scripts/dev.sh Outdated Show resolved Hide resolved

Tguntenaar added 10 commits November 16, 2023 13:16

fix: replace strings before bos-loader is called

9d34288

remove dist

ed13d73

refac Tag to transpile to MainComponent

212141b

change transpiledPathPrefix to build/src

cc3f945

rename BaseProps to DevHubBaseProps

31fd311

transpile to build/src

3f85dc2

change REPL_DEVHUB_CONTRACT replacement back to devgovgigs.near

b389bee

wip: move replacements to js script and out of dev.sh (mac only) and …

0fef9cc

…out of github action

Merge branch 'main' of github.com:Tguntenaar/neardevhub-widgets into …

ff0d9cc

…feature/456-move-to-typescript

lint

7402aa4

Tguntenaar added 3 commits November 19, 2023 14:53

refac: remove include from history

7055b67

refac: remove INCLUDE: and add autocomplete module

1a3095f

remove: unused legacy include.js

6cd31b9

Tguntenaar mentioned this pull request Nov 19, 2023

Saving attributions to metadata NEARBuilders/bos-workspace#28

Open

Tguntenaar added 3 commits November 19, 2023 15:34

fix: deploy bos components from ./build working directory

f7e935c

feat: add watchman to build files on change

8401e47

remove node package fb-watchman

c3a9b3e

Tguntenaar commented Nov 19, 2023

View reviewed changes

scripts/dev.sh Show resolved Hide resolved

src/devhub/entity/community/Tile.jsx Outdated Show resolved Hide resolved

fix: pipeline test issue caused by watchman

61d8515

Tguntenaar marked this pull request as ready for review November 19, 2023 15:44

Tguntenaar requested a review from ailisp as a code owner November 19, 2023 15:44

changed: use watcher instead of fb-watchman

9124104

frol marked this pull request as draft December 5, 2023 23:33

Tguntenaar added 7 commits December 11, 2023 13:12

remove fb-watch commands

627e815

added options to watch

38b8f33

blocked, running npm run watch from dev.sh rebuilds too often

f632786

Merge branch 'main' of github.com:near/neardevhub-widgets into featur…

b1234fb

…e/456-move-to-typescript

feat: trap bos-loader and run watch parallel

d3ddfb8

update: contribution.md on the dev process

0e1b8b6

remove watchmanconfig

4daba20

Tguntenaar commented Dec 13, 2023

View reviewed changes

Tguntenaar marked this pull request as ready for review December 13, 2023 10:19

Merge branch 'main' of github.com:near/neardevhub-widgets into featur…

ffd8467

…e/456-move-to-typescript

frol approved these changes Dec 18, 2023

View reviewed changes

CONTRIBUTING.md Outdated Show resolved Hide resolved

Update CONTRIBUTING.md zsh -> sh

5d4f9fb

Tguntenaar added 4 commits December 21, 2023 10:35

Merge branch 'main' of github.com:near/neardevhub-widgets into featur…

d040a65

…e/456-move-to-typescript

update import statement

be0e662

edit the CONTRIBUTING deploy preview steps

01969d3

Merge branch 'main' into feature/456-move-to-typescript

9e1fb7c

Tguntenaar added 2 commits January 4, 2024 10:51

Merge branch 'main' of github.com:near/neardevhub-widgets into featur…

ced9056

…e/456-move-to-typescript

fmt

e5559cd

Tguntenaar merged commit 8f28dbb into NEAR-DevHub:main Jan 4, 2024
2 checks passed

elliotBraem reviewed Jan 5, 2024

View reviewed changes

elliotBraem added a commit that referenced this pull request Jan 9, 2024

Revert "initial typescript support (#468)"

d81cfc5

This reverts commit 8f28dbb.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

initial typescript support #468

initial typescript support #468

Tguntenaar commented Nov 14, 2023 •

edited

Loading

Tguntenaar commented Nov 14, 2023

frol left a comment

Tguntenaar commented Nov 19, 2023 •

edited

Loading

Tguntenaar left a comment

frol left a comment

Megha-Dev-19 commented Dec 18, 2023

ailisp commented Dec 20, 2023

elliotBraem commented Jan 3, 2024 •

edited

Loading

elliotBraem Jan 5, 2024

Tguntenaar Jan 5, 2024

elliotBraem Jan 5, 2024

elliotBraem Jan 5, 2024

initial typescript support #468

initial typescript support #468

Conversation

Tguntenaar commented Nov 14, 2023 • edited Loading

Tguntenaar commented Nov 14, 2023

frol left a comment

Choose a reason for hiding this comment

Tguntenaar commented Nov 19, 2023 • edited Loading

Tguntenaar left a comment

Choose a reason for hiding this comment

frol left a comment

Choose a reason for hiding this comment

Megha-Dev-19 commented Dec 18, 2023

ailisp commented Dec 20, 2023

elliotBraem commented Jan 3, 2024 • edited Loading

elliotBraem Jan 5, 2024

Choose a reason for hiding this comment

Tguntenaar Jan 5, 2024

Choose a reason for hiding this comment

elliotBraem Jan 5, 2024

Choose a reason for hiding this comment

elliotBraem Jan 5, 2024

Choose a reason for hiding this comment

Tguntenaar commented Nov 14, 2023 •

edited

Loading

Tguntenaar commented Nov 19, 2023 •

edited

Loading

elliotBraem commented Jan 3, 2024 •

edited

Loading