Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes deposit and reduces gas (#551) #552

Merged
merged 1 commit into from
Dec 6, 2023
Merged

removes deposit and reduces gas (#551) #552

merged 1 commit into from
Dec 6, 2023

Conversation

elliotBraem
Copy link
Contributor

@elliotBraem elliotBraem commented Dec 5, 2023

Resolves #549

This removes the deposit from all function calls to DevHub contract in our codebase, and set the gas for all of them to Big(10).pow(14) (MAX_GAS)

PREVIEW

@elliotBraem elliotBraem marked this pull request as ready for review December 6, 2023 17:44
@elliotBraem elliotBraem merged commit ebf452f into main Dec 6, 2023
5 checks passed
@elliotBraem elliotBraem deleted the develop branch December 6, 2023 18:17
@elliotBraem elliotBraem restored the develop branch December 6, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deposit should be zero and gas should not exceed allowance or max gas for a transaction
1 participant