Tweaks #41
Tweaks #41
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Vercel deployment is failing, probably because of trying to access client-side window in a server side component 
|
| <ProjectCard key={pid} project={projects[pid]} maxWidth /> | ||
| ))} | ||
| {loading | ||
| ? Array.from({ length: 4 }).map((_, index) => ( |
There was a problem hiding this comment.
I felt it was smoother before -- and I think the loading section showing project skeletons -> "no bookmarks found" is a a bit jarring; seems to take longer to load too with loading state defaulting to true.
There was a problem hiding this comment.
Yeah, thinking more about it -- especially since this is dependent on local storage starred projects, rather than the "fetchAllProjects" -- we shouldn't be getting hung up on this fetch. Either there are no starredProjects, or there are and then we need fetch
There was a problem hiding this comment.
ok, i'll revert
components/search-input.tsx
Outdated
| return ( | ||
| <div className="container relative mx-auto"> | ||
| <input | ||
| ref={inputRef} | ||
| type="text" | ||
| name="search" | ||
| value={searchKey} |
There was a problem hiding this comment.
Hmmm I don't know for certain, but isn't this the same as
<input autoFocus onFocus={(e) => e.target.select()} />?
| @@ -1,22 +1,40 @@ | |||
| "use client"; | |||
There was a problem hiding this comment.
Why was "use client" introduced? Is it because of the useSearchStore?
An alternative may be to keep the useSearchStore outside and have this component take a loading prop. Keep it as "projects.length === 0" shows none found. Then set loading in whatever is calling it -- I see there was a bit of a hack put in for category-project-list to make this work
Improve Lightouse Scores for Project Page, Category Page, Bookmarks Page
Fix misc bugs
EDIT: TOTAL REFACTOR