Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install cryptography Python library #213

Merged
merged 9 commits into from
Sep 7, 2023
Merged

Conversation

widhalmt
Copy link
Member

@widhalmt widhalmt commented Aug 4, 2023

We had this as a requirement. But it makes sense to have the role install the library without any further interaction with the user.

fixes #212

We had this as a requirement. But it makes sense to have the role
install the library without any further interaction with the user.

fixes #212
@widhalmt widhalmt added the feature New feature or request label Aug 4, 2023
@widhalmt widhalmt added this to the 1.1.0 milestone Aug 4, 2023
@widhalmt widhalmt self-assigned this Aug 4, 2023
@widhalmt widhalmt marked this pull request as draft August 4, 2023 16:45
Saeid-Abadi
Saeid-Abadi previously approved these changes Aug 7, 2023
@widhalmt widhalmt added the help wanted Extra attention is needed label Aug 8, 2023
@widhalmt
Copy link
Member Author

widhalmt commented Aug 8, 2023

It looks like the package is still named something else in Ubuntu systems. To be honest, I don't know how to proceed. It feels like the package is named differently across all supported OSes. And forcing to use pip doesn't feel right, either.

Has anyone of you a better idea?

@Saeid-Abadi Saeid-Abadi self-requested a review August 9, 2023 07:20
@danopt
Copy link
Member

danopt commented Aug 18, 2023

Hmm, I checked it on different OS. As far as I can see, all newer OS use python3 and the package is available under python3-cryptography. The only one I know where python-cryptography >= 2.5 is not available within the system package manager is CentOS 7. There we will need to install it with pip.

That should be convention after PEP 394 and most distributions following this recommendation except for Windows. (https://stackoverflow.com/questions/62214293/is-python3-always-installed-with-python-3)

I double checked it on these OS:
Rockylinux 8
Python 3.6.8 (default, Jun 22 2023, 05:10:43)
python3-cryptography

Debian 11
Python 3.9.2 (default, Feb 28 2021, 17:03:44)
python3-cryptography

Ubuntu 20.04
Python 3.8.10 (default, May 26 2023, 14:05:08)
python3-cryptography

Ubuntu 22.04
Python 3.10.12 (main, Jun 11 2023, 05:26:28) [GCC 11.4.0] on linux
python3-cryptography

For older systems the user can change the package to python-cryptography instead of python3-cryptography or/and we could offer an alternative installation with pip. The installation hasn't to be system-wide if we give pip the --user parameter for installation.

Am I missing something?

@widhalmt
Copy link
Member Author

I guess, you're right. I'm just living in the past.... I go for python3-cryptography then.

@widhalmt widhalmt marked this pull request as ready for review August 21, 2023 12:22
@widhalmt widhalmt removed the help wanted Extra attention is needed label Aug 22, 2023
@widhalmt
Copy link
Member Author

widhalmt commented Aug 23, 2023

I'll wait for #179 and #243 to be merged before resolving these conflicts. This should give us working tests. Finally.

@widhalmt
Copy link
Member Author

widhalmt commented Sep 5, 2023

Looks like repositories of Rocky Linux are facing some issues right now. I'll try later and rerun the failing tests.

Copy link
Member

@afeefghannam89 afeefghannam89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me :)

@widhalmt widhalmt added this pull request to the merge queue Sep 7, 2023
Merged via the queue into main with commit c2dc529 Sep 7, 2023
@widhalmt widhalmt deleted the feature/cryptography-212 branch September 7, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically install Python cryptography module
4 participants