"Create New Microgame" option in menu #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Please test your changes using this link! ✨👉 https://polite-glacier-037563110.2.azurestaticapps.net 👈✨ |
|
🎉 Please test your changes using this link! ✨👉 https://polite-glacier-037563110.2.azurestaticapps.net 👈✨ |
|
🎉 Please test your changes using this link! ✨👉 https://polite-glacier-037563110.2.azurestaticapps.net 👈✨ |
|
🎉 Please test your changes using this link! ✨👉 https://polite-glacier-037563110.2.azurestaticapps.net 👈✨ |
|
🎉 Please test your changes using this link! ✨👉 https://polite-glacier-037563110.2.azurestaticapps.net 👈✨ |
Arshea
approved these changes
Sep 28, 2023
|
|
||
| enum InputType { | ||
| MASH, # TODO - i don't love this for arrows+button but it seems to be the (WarioWare) Gold standard | ||
| } |
There was a problem hiding this comment.
I usually have the last type of an enum be "SIZE" and have found that it's quite a useful bookend in an enum.
- You could query how many input types you have (InputType.SIZE)
- It feels like you're restricting the enum on one end - you can add things before SIZE, but not after it. Which is helpful when enums show in editor dropdowns because reordering an enum messes up what a dropdown is set to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.