Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Person and StudyParticipant profiles to the Participant module #28

Merged
merged 7 commits into from
Jul 30, 2024

Conversation

brendagutman
Copy link
Collaborator

@brendagutman brendagutman commented Jul 24, 2024

Motivation

Add the Person and StudyParticipant profiles to the Participant module.

When the base branch(participant) is merged three new FHIR profiles will exist in the implementation guide.

Approach

Add FHIR logical models, profiles, and examples for each additional profile.

@github-actions github-actions bot temporarily deployed to pull request July 24, 2024 21:08 Inactive
Copy link

github-actions bot commented Jul 24, 2024

🚀 IG Site Preview Deployed

Latest commit: e695b21

View deployment

@brendagutman brendagutman changed the title Bg participant Add the Person and StudyParticipant profiles to the Participant module Jul 26, 2024
@github-actions github-actions bot temporarily deployed to pull request July 26, 2024 11:17 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 26, 2024 11:19 Inactive
Copy link
Collaborator

@torstees torstees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some files that should be removed and some various tweaks that I am recommending be done. Otherwise, this is looking great!

_gencontinuous.bat Outdated Show resolved Hide resolved
_gencontinuous.sh Outdated Show resolved Hide resolved
_genonce.sh Outdated Show resolved Hide resolved
input/fsh/examples/participant.fsh Outdated Show resolved Hide resolved
input/fsh/modules/participant.fsh Outdated Show resolved Hide resolved
input/fsh/modules/participant.fsh Outdated Show resolved Hide resolved
input/fsh/modules/participant.fsh Outdated Show resolved Hide resolved
input/fsh/modules/participant.fsh Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request July 29, 2024 15:25 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 29, 2024 17:00 Inactive
@brendagutman
Copy link
Collaborator Author

brendagutman commented Jul 29, 2024

There are some files that should be removed and some various tweaks that I am recommending be done. Otherwise, this is looking great!

@torstees Should I add the .sh and .bat to the gitignore?

Copy link
Collaborator

@torstees torstees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to add the 1 or more cardinality to link (I misspoke when I suggested link.target

input/fsh/modules/participant.fsh Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request July 29, 2024 18:30 Inactive
Copy link
Collaborator

@torstees torstees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@brendagutman brendagutman merged commit cef3501 into participant Jul 30, 2024
1 check passed
@brendagutman
Copy link
Collaborator Author

  • ✨ Add Person and Study Participant Modules

  • 🚧 Add Stub Studies and Consents to the Participant Examples

  • 🚧 Update Person and StudyParticipant pagecontent

  • 🚧 Revert changes to .sh and .bat files

  • 🚧 Remove gencontinuous files

  • 🚧 Make suggested changes

  • 🚧 Suggested change to NcpiPerson link


Co-authored-by: Brenda gutmanb@VAWDKG4Q04

torstees added a commit that referenced this pull request Jul 30, 2024
* Actual products of the sushi run

* Participant initial pass

* Additional clarity for profile 'info'

* Refinement of the above

* Added key Aliases for OMB, NCIT and UCUM

* Fixed a few lingering errors

* Removed draft to strip out extraneous warning/error in QA

* Fixed some issues with broken links

* Largely functional participant profile(s) and first example

* Clearer wording and proper format of link

* First example for patient

* 🙈 Ignore temp vim files

* 📝 Initial repo contributors guide

* ✨ Add versioning, release, emoji commits, and emoji PRs

* ♻️ Add link to contrib guide on readme

* ♻️ Incorporate PR comments

* ♻️ Clean up and make sdlc steps more clear

* Added extension relating to sex at birth

* Beginnings of the technical writing as example for IG Contributors.

* Fixed some broken links due to case

* Add the Person and StudyParticipant profiles to the Participant module (#28)

* ✨ Add Person and Study Participant Modules

---------

Co-authored-by: Natasha Singh <[email protected]>
Co-authored-by: brendagutman <[email protected]>
@brendagutman brendagutman deleted the bg_participant branch August 8, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants