Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #31

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Refactor #31

wants to merge 11 commits into from

Conversation

esan0
Copy link
Contributor

@esan0 esan0 commented Oct 4, 2023

Hi team,

I started working on a refactor of the plugin.
This is very much a work in progress and may take some time.

Goal

  • Clean up code
  • Break out subprocesses into functions
  • More html text out into separate module
  • Enhance UI
    • Add tab that shows output extent preview with overlayed tiling
  • Fix zoom/extent lock

Questions

  • pylintrc currently sets the line length to 80 -- can we change this?
    • It feels a bit cramped and I'm more used to 100
    • Let me know if there are any issues with this
  • The # -*- coding: utf-8 -*- I think is not necessary -- any objection to removing them from the project?

Progress

  • Linter errors/warnings
  • Simplify code
  • Move html text into separate module
  • Add preview tab to UI
  • Fix zoom/extent lock

- Dead link to garmin discussion forums talkinga about the size
  limitations fixed
- started fixing linter warnings and errors
@esan0 esan0 self-assigned this Oct 4, 2023
* It's not called anywhere, and the plugin runs successfully without it
* Moved the CRS warning into separate functions
* Moved main dialog text into top level constant
* Added some typing
* changed output file dialog name
* Also added gdal debug info function
* Changed variable names in tile producing logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant