Dotplot : Added functionality to plot multiple dots,Fixed some errors in plot_line function #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djmgit
requested changes
Feb 1, 2018
|
@realsdx Nice work, just a few suggestions which you can follow from next time. Welcome On board. |
|
Deleted test.py |
|
Thanks for the suggestion. |
|
No.. that time I don't know that I can't remove a file from remote using gitignore |
|
@realsdx Congrats, your first PR has been merged. From next time, when you make multiple commits, please squash them into a single one before making PR :) It keeps things more organised :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17 Added functionality to plot multiple dots (even single) on a figure.
#85 Fixed all the issues mentioned here except Documentation