Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment in leaderboard (responsively) #78

Closed

Conversation

paramsiddharth
Copy link
Contributor

@paramsiddharth paramsiddharth commented Dec 26, 2020

Fix alignment in leaderboard (responsively)

Resolves #77: Fix alignment on participants

Modifications

  • style.css modified to fix width of each column in the table.
  • The positions are aligned to the right within the first column.
  • The names start from the same distance from the left in each row.
  • The scores are aligned to the right.
  • The final version is made responsive using @media queries.

Comparison

  • Previous format:
    Desktop Mobile
    image image
  • New format:
    Desktop Mobile
    image image

Additional Information

After the update in #79, the result would be as follows:

Desktop Mobile
image image

@vercel
Copy link

vercel bot commented Dec 26, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nwoc/nwoc-website-alpha-deployment/f7nzr3j5q
✅ Preview: https://nwoc-website-a-git-fork-paramsiddharth-alignm-c496d5.nwoc.vercel.app

Copy link
Member

@s-ayush2903 s-ayush2903 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paramsiddharth We don't want the positions and scores to be constrained to the extreme right, they(including handles) should be in proper centred alignment with their column titles

@s-ayush2903
Copy link
Member

@paramsiddharth Are you able to work on this PR further?

@paramsiddharth
Copy link
Contributor Author

@paramsiddharth Are you able to work on this PR further?

@s-ayush2903 Yes, I'll finish it soon.

@ashwaniYDV
Copy link
Member

hi @paramsiddharth
Is this PR ready to be merged?

@paramsiddharth
Copy link
Contributor Author

hi @paramsiddharth
Is this PR ready to be merged?

No, @ashwaniYDV . I am not working on it at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix alignment on participants
3 participants