perf: improve performance and fix potential problems

NJUPT-SAST · Aug 29, 2024 · 75856c0 · 75856c0
1 parent 806b1a1
commit 75856c0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/Infrastructure/Network/NetworkClient.cc b/src/Infrastructure/Network/NetworkClient.cc
@@ -4,6 +4,7 @@
 #include <Infrastructure/Utils/Debug.h>
 #include <boost/url/param.hpp>
 #include <boost/url/params_view.hpp>
+#include <initializer_list>
 #include <memory>
 #include <nlohmann/json.hpp>
 #include <string>

diff --git a/src/Infrastructure/Network/NetworkClient.h b/src/Infrastructure/Network/NetworkClient.h
@@ -100,12 +100,12 @@ class NetworkClient {
     NetworkClient(net::ssl::context& ctx);
     static NetworkClient* getInstance();
     //cache data processing
-    std::string generateCacheKey(
+    static std::string generateCacheKey(
         http::verb verb,
         const urls::url_view& url,
         const std::initializer_list<urls::param>& params); //auxiliary function to generate cache key
 
-    bool isCacheEntryExpired(const CacheEntry& entry) const {
+    static bool isCacheEntryExpired(const CacheEntry& entry) const {
         auto now = std::chrono::steady_clock::now();
         auto duration = std::chrono::duration_cast<std::chrono::hours>(now - entry.insertTime);
         return duration.count() >= 3;
@@ -117,7 +117,7 @@ class NetworkClient {
                 cacheList.erase(it->second);
                 currentCacheSize -= it->second->second.size;
             }
-            cacheList.push_front({key, std::move(entry)});
+            cacheList.emplace_front({key, std::move(entry)});
             cacheMap[key] = cacheList.begin();
             currentCacheSize += cacheList.begin()->second.size;