Merge branch 'dev' into feat/net/cache

.clang-tidy

@@ -2,7 +2,6 @@
 Checks:          'clang-diagnostic-*,clang-analyzer-*,-*,performance-*,readability-*,bugprone-*,clang-analyzer-*,cppcoreguidelines-*,mpi-*,misc-*,-readability-magic-numbers,-cppcoreguidelines-avoid-magic-numbers,-misc-non-private-member-variables-in-classes,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-type-vararg,-clang-analyzer-optin.mpi*,-bugprone-exception-escape,-cppcoreguidelines-pro-bounds-pointer-arithmetic'
 WarningsAsErrors: ''
 HeaderFilterRegex: ''
-AnalyzeTemporaryDtors: false
 FormatStyle:     file
 CheckOptions:
   - key:             performance-unnecessary-copy-initialization.ExcludedContainerTypes

.github/workflows/clang-tidy-review.yml

@@ -42,18 +42,26 @@ jobs:
             !${{ github.workspace }}/build/corrosion/**/target/**/incremental
           key: corrosion-${{ runner.os }}
 
+      - name: Setup CMake
+        uses: lukka/get-cmake@latest
+
       - name: Setup vcpkg
         uses: lukka/run-vcpkg@v11
         with:
           vcpkgConfigurationJsonGlob: 'vcpkg-configuration.json'
           vcpkgJsonGlob: 'vcpkg.json'
 
+      - name: CMake Generate
+        run: cmake --preset native -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
+
       - name: Run clang-tidy
         uses: ZedThree/[email protected]
         id: review
         with:
           build_dir: build
           config_file: ".clang-tidy"
           exclude: "3rdpart/*, build/*"
-          cmake_command: |
-            cmake --preset native -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
+
+      - name: If there are any comments, fail the check
+        if: steps.review.outputs.total_comments > 0
+        run: exit 1

.github/workflows/codeql.yml

@@ -10,6 +10,9 @@ on:
     - "CMakePresets.json"
     - "vcpkg*"
     - ".github/workflows/codeql.yml"
+    branches:
+      - main
+      - dev
   pull_request:
     paths:
     - "src/**"

.github/workflows/format-check.yml

@@ -8,6 +8,10 @@ on:
     paths: 
     - "src/**"
     - ".github/workflows/format-check.yml"
+    branches:
+      - main
+      - dev
+
 jobs:
   format-check:
     name: Format Check

src/Controller/Core/AccountManager.h

@@ -8,7 +8,7 @@
 
 EVENTO_UI_START
 
-class AccountManager : private GlobalAgent<::AccountManager>,
+class AccountManager : private GlobalAgent<AccountManagerBridge>,
                        std::enable_shared_from_this<AccountManager> {
     friend class UiBridge;
     UiBridge& bridge;

src/Controller/Core/MessageManager.h

@@ -8,7 +8,7 @@
 
 EVENTO_UI_START
 
-class MessageManager : GlobalAgent<::MessageManager> {
+class MessageManager : GlobalAgent<MessageManagerBridge> {
     friend class UiBridge;
     UiBridge& bridge;
     std::string logOrigin = "MessageManager";

src/Controller/Core/ViewManager.cc

@@ -143,9 +143,8 @@ void ViewManager::hideView(ViewName target) {
     visibleViews.erase(target);
 }
 
-void ViewManager::onEnterEventLoop() {
-    auto stack = viewStack;
-}
+void ViewManager::onEnterEventLoop() {}
+
 void ViewManager::onExitEventLoop() {
     // clean up
     spdlog::debug("ViewManager: --- onExitEventLoop: clean up all pages ---");

src/Controller/Core/ViewManager.h

@@ -9,7 +9,7 @@
 
 EVENTO_UI_START
 
-class ViewManager : private GlobalAgent<::ViewManager> {
+class ViewManager : private GlobalAgent<ViewManagerBridge> {
     friend class UiBridge;
     UiBridge& bridge;
     std::string logOrigin = "ViewManager";
@@ -26,12 +26,15 @@ class ViewManager : private GlobalAgent<::ViewManager> {
     // view will be added to stack and show on top, overlay won't hide prior view.
     // auto refresh
     void navigateTo(ViewName newView);
+
     // stack will be clean (init view left), and push new view.
     // auto refresh
     void cleanNavigateTo(ViewName newView);
+
     // current page pop and new view pushed.
     // auto refresh
     void replaceNavigateTo(ViewName newView);
+
     // view will be pop from stack, new top will be show if it not.
     // auto refresh
     void priorView();

src/Controller/UiBridge.cc

@@ -25,11 +25,12 @@ UiBridge::UiBridge(slint::ComponentHandle<UiEntryName> uiEntry)
     , messageManager(std::make_shared<MessageManager>(uiEntry, *this)) {
     attachAllViews();
 
+    slint::invoke_from_event_loop([this] { return onEnterEventLoop(); });
+
     uiEntry->window().on_close_requested([this] {
         onExitEventLoop();
         return slint::CloseRequestResponse::HideWindow;
     });
-    slint::invoke_from_event_loop([this] { return onEnterEventLoop(); });
 
     viewManager->initStack(ViewName::DiscoveryPage);
     if (!accountManager->isLogin()) {

src/Controller/UiBridge.h

@@ -9,6 +9,7 @@ EVENTO_UI_START
 class UiBridge : GlobalAgent<::UiBridge> {
     friend class ViewManager;
     friend class AccountManager;
+    friend class MessageManager;
 
     slint::ComponentHandle<UiEntryName> uiEntry;
     bool eventLoopRunning = false;

ui/app.slint

@@ -3,10 +3,13 @@ import { Token } from "./global.slint";
 import { Button } from "std-widgets.slint";
 import { Empty } from "./components/index.slint";
 import { 
+    ViewManagerBridge,
+    AccountManagerBridge,
+    MessageManagerBridge,
     ViewManager,
-    ViewName,
     AccountManager,
     MessageManager,
+    ViewName,
     MessageType
 } from "./logic/index.slint";
 
@@ -35,10 +38,13 @@ import { SAlert } from "modules/surrealism-ui/src/alert/index.slint";
 
 // export for C++ interact
 export { 
+    ViewManagerBridge,
+    AccountManagerBridge,
+    MessageManagerBridge,
     ViewManager,
-    ViewName,
     AccountManager,
     MessageManager,
+    ViewName,
     MessageType,
     LoginOverlayBridge,
     MenuOverlayBridge,

ui/logic/account_manager.slint

@@ -1,5 +1,15 @@
-export global AccountManager {
+export global AccountManagerBridge {
     in-out property <bool> is-login;
     callback request-login();
     callback request-logout();
 }
+
+export global AccountManager {
+    out property <bool> is-login <=> AccountManagerBridge.is-login;
+    public function request-login() {
+        AccountManagerBridge.request-login();
+    }
+    public function request-logout() {
+        AccountManagerBridge.request-logout();
+    }
+}

ui/logic/index.slint

@@ -1,10 +1,15 @@
 export { EventoStyleToken } from "./style_token.slint";
 export { 
     ViewManager,
+    ViewManagerBridge,
     ViewName,
 } from "./view_manager.slint";
-export { AccountManager } from "./account_manager.slint";
+export { 
+    AccountManager,
+    AccountManagerBridge,
+} from "./account_manager.slint";
 export { 
     MessageManager,
+    MessageManagerBridge,
     MessageType,
 } from "./message_manager.slint";

ui/logic/message_manager.slint

@@ -4,10 +4,20 @@ export enum MessageType{
     Error
 }
 
-export global MessageManager {
+export global MessageManagerBridge {
     in-out property <string> content: "Test content";
     in-out property <bool> visible;
     in-out property <MessageType> type;
     in-out property <duration> timeout: 3s;
     callback show-message(string, MessageType);
 }
+
+export global MessageManager {
+    out property <string> content <=> MessageManagerBridge.content;
+    out property <bool> visible <=> MessageManagerBridge.visible;
+    out property <MessageType> type <=> MessageManagerBridge.type;
+    out property <duration> timeout <=> MessageManagerBridge.timeout;
+    public function show-message(content: string, type: MessageType) {
+        MessageManagerBridge.show-message(content, type);
+    }
+}

ui/logic/view_manager.slint

@@ -10,7 +10,7 @@ export enum ViewName{
     MenuOverlay,
 }
 
-export global ViewManager {
+export global ViewManagerBridge {
     // nav request
     callback navigate-to(ViewName);
     callback clean-navigate-to(ViewName);
@@ -20,3 +20,23 @@ export global ViewManager {
     pure callback is-show(ViewName) -> bool;
     in-out property <bool> refresh;
 }
+
+export global ViewManager {
+    // nav request
+    public function navigate-to(view: ViewName) {
+        ViewManagerBridge.navigate-to(view);
+    }
+    public function clean-navigate-to(view: ViewName) {
+        ViewManagerBridge.clean-navigate-to(view);
+    }
+    public function replace-navigate-to(view: ViewName) {
+        ViewManagerBridge.replace-navigate-to(view);
+    }
+    public function prior-view() {
+        ViewManagerBridge.prior-view();
+    }
+    // control view visibility
+    public pure function is-show(view: ViewName) -> bool {
+        return ViewManagerBridge.is-show(view);
+    }
+}