feat(ui): finish about page #27

RooobinYe · 2024-08-15T04:45:22Z

「TODO LIST」

button：前往下载/取消
如果没有更新，就显示「已是最新版本」

format 问题：已经注意到了，下次更新解决
修 bug：没有滑动框

RooobinYe · 2024-08-15T04:46:37Z

Linked with #8

cEvolve05 · 2024-08-15T05:17:12Z

应当合并到dev而不是main

ArcticLampyrid · 2024-08-15T05:23:12Z

也许应当加上我们自己的应用图标、应用介绍、贡献者列表等内容

RooobinYe · 2024-08-15T05:28:06Z

也许应当加上我们自己的应用图标、应用介绍、贡献者列表等内容

嗯嗯对的还没写完

主要是 about page 没有设计稿我要参考一下其他的 about page 是什么样的

ui/views/page/about.slint

github-actions · 2024-08-19T16:57:30Z

clang-tidy review says "All clean, LGTM! 👍"

RooobinYe · 2024-08-19T16:59:21Z

已经完成前端的主要工作

目前的想法是：点击「检查更新」按钮会通过 checkUpdate() 进行一个 callback，之后根据版本情况，显示「已是最新」或者「需要更新」的 text
如果需要更新则自动跳转到 GitHub 的 releases 页面
但是 .cc 和 .h 文件不太会写，我明天再研究一下

RooobinYe · 2024-08-19T17:01:57Z

抱歉由于一些待完成的工作导致编译没过已经重新 git pull 了

github-actions · 2024-08-19T17:03:27Z

clang-tidy review says "All clean, LGTM! 👍"

Serein207 · 2024-08-20T00:30:51Z

版本信息放在单独的圆角矩形框内，需要显示更新日志
不要用冒号做分隔，改成左右分散对齐
网页版改成独立一栏
链接用 SLink 组件标注
license 栏直接改成 "开源协议 MIT license Copyright (c) 2024 NJUPT-SAST"
”开发使用框架/组件库“改名“项目依赖”
“开发者名单” 改名 “贡献者”，并且本栏只显示头像，注意排版
网络请求逻辑应该是在 slint 中设置本页面的全局 status 状态枚举值，包括 loading, success, error 三个状态，相关组件根据这三个状态更改自己的显示逻辑，在C++的回调中根据当前情况设置全局状态量，如请求发起前进入loading状态，请求成功后更新数据，然后更改为success状态，error状态需要刷新按钮重新请求数据
建议单独为需要网络请求的信息加入懒加载逻辑，进入页面后在组件中适当位置显示加载 icon 动画

github-actions · 2024-08-20T12:19:40Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-08-20T13:54:32Z

clang-tidy review says "All clean, LGTM! 👍"

RooobinYe · 2024-08-20T14:05:37Z

添加另一个「项目依赖」栏的新功能
当 width 低于某个值时：

当 width 高于某个值时：

目前存在的 bug：
我无法点击「使用 Link 登录」（点击按钮没有反应）macOS 系统

此外，CMakeLists.txt 文件我必须删去第十一行中的「x86_64」我才能顺利编译（apple Silicon chip）

RooobinYe · 2024-08-20T14:09:37Z

此外，麻烦师傅们有空的时候能不能看一下 AboutPage.cc 我注释掉的部分呀这部分的功能是打开网站但是不知道为什么编译不过（可能是我技术不到位写的代码有问题）
感觉有点到瓶颈期了师傅们能不能指点一下 .cc 文件的编写呀不胜感谢～

Serein207 · 2024-08-20T14:41:06Z

文件格式化一下
把仓库链接最后面的 / 去掉

目前存在的 bug：我无法点击「使用 Link 登录」（点击按钮没有反应）macOS 系统

sast-link-cxx-sdk 的bug，已修复，等待明天合入 dev 分支

此外，CMakeLists.txt 文件我必须删去第十一行中的「x86_64」我才能顺利编译（apple Silicon chip）

@ArcticLampyrid 能处理一下吗

此外，麻烦师傅们有空的时候能不能看一下 AboutPage.cc 我注释掉的部分呀这部分的功能是打开网站但是不知道为什么编译不过（可能是我技术不到位写的代码有问题）

lambda表达式写的不对，看文档

dev 分支最新提交新增了跨平台的 openBrowser 函数，在 src/Infrastructure/Utils/Tools.h

RooobinYe · 2024-08-22T15:42:14Z

已知的 bug：
弹窗没有滑动条明天修

* feat:some basic laying * feat(ui): basic laying on the page * ui laying primary draft * feat(ui): callbacks and root * attempt to fill in .cc and .slint * callbacks fiied * feat: setting page * feat: change theme when app start * chore: clean up code * feat(ui): add scroll view in setting page --------- Co-authored-by: Serein <[email protected]>

github-actions · 2024-08-22T17:54:39Z

clang-tidy review says "All clean, LGTM! 👍"

RooobinYe · 2024-08-23T16:12:48Z

增加了动画，修缮了一点小细节
.cc 文件的网络请求好难写啊 QAQ
😭

github-actions · 2024-08-23T16:14:04Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-09-04T12:13:49Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-09-04T12:17:57Z

clang-tidy review says "All clean, LGTM! 👍"

…st-evento into feat/ui/about-page

github-actions · 2024-09-04T12:52:02Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-09-04T13:05:05Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions

clang-tidy made some suggestions

github-actions · 2024-09-05T13:59:51Z

src/Controller/View/AboutPage.cc

+                executor()
+                    ->asyncExecute(networkClient()->getFile(contributors[i].avatar_url),
+                                   [&self = *this, i](Result<std::filesystem::path> result) {
+                                       if (result.isErr()) {


warning: if with identical then and else branches [bugprone-branch-clone]

if (result.isErr()) { ^

Additional context

src/Controller/View/AboutPage.cc:53: else branch starts here

} else { ^

dismiss

feat(ui): Finish about page

38786d5

RooobinYe added the feature New feature or request label Aug 15, 2024

RooobinYe changed the title ~~feat(ui): Finish about page~~ feat(ui): finish about page Aug 15, 2024

cEvolve05 linked an issue Aug 15, 2024 that may be closed by this pull request

feat(ui): implement about page #8

Closed

cEvolve05 self-requested a review August 15, 2024 05:17

RooobinYe changed the base branch from main to dev August 15, 2024 05:18

cEvolve05 previously requested changes Aug 15, 2024

View reviewed changes

ui/views/page/about.slint Outdated Show resolved Hide resolved

ui/views/page/about.slint Outdated Show resolved Hide resolved

cEvolve05 assigned RooobinYe Aug 15, 2024

Serein207 linked an issue Aug 16, 2024 that may be closed by this pull request

feat(ui): about page #1

Closed

RooobinYe added 2 commits August 19, 2024 23:26

Merge branch 'dev' into feat/ui/about-page

65553e6

Feat: finish about.slint

de22e2d

Fix build bugs in AboutPage.cc

cded79d

NJUPT-SAST deleted a comment from RooobinYe Aug 20, 2024

Merge branch 'dev' into feat/ui/about-page

f0ee2af

Update

5c84ff1

Serein207 requested a review from cEvolve05 August 20, 2024 23:55

Update

119d386

DTPA101 and others added 4 commits August 23, 2024 00:37

refactor: about page

a33a89d

fix(ui): scroll view

0d38cb5

Merge branch 'dev' into feat/ui/about-page

9b42dac

Serein207 force-pushed the dev branch from 0d38cb5 to 08de0cc Compare August 22, 2024 17:51

Merge branch 'dev' into feat/ui/about-page

8637ca6

Update

25621f6

RooobinYe and others added 3 commits September 4, 2024 15:14

Merge branch 'dev' into feat/ui/about-page

dedebb1

Merge branch 'dev' into feat/ui/about-page

c205b1c

fix

57b7c51

Serein207 force-pushed the feat/ui/about-page branch from ab0ae83 to 57b7c51 Compare September 4, 2024 12:14

Merge branch 'feat/ui/about-page' of https://github.com/NJUPT-SAST/sa…

c6e7c8f

…st-evento into feat/ui/about-page

fix button

a0bd6b9

Serein207 added 2 commits September 5, 2024 21:53

feat: finish page

9b181dc

Merge branch 'dev' into feat/ui/about-page

fbaba7e

Serein207 marked this pull request as ready for review September 5, 2024 13:55

github-actions bot reviewed Sep 5, 2024

View reviewed changes

Serein207 approved these changes Sep 5, 2024

View reviewed changes

Serein207 merged commit b9e737a into dev Sep 5, 2024
5 checks passed

Serein207 deleted the feat/ui/about-page branch September 5, 2024 14:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ui): finish about page #27

feat(ui): finish about page #27

RooobinYe commented Aug 15, 2024 •

edited

Loading

RooobinYe commented Aug 15, 2024 •

edited

Loading

cEvolve05 commented Aug 15, 2024

ArcticLampyrid commented Aug 15, 2024

RooobinYe commented Aug 15, 2024

github-actions bot commented Aug 19, 2024

RooobinYe commented Aug 19, 2024 •

edited

Loading

RooobinYe commented Aug 19, 2024

github-actions bot commented Aug 19, 2024

Serein207 commented Aug 20, 2024 •

edited

Loading

github-actions bot commented Aug 20, 2024

github-actions bot commented Aug 20, 2024

RooobinYe commented Aug 20, 2024 •

edited

Loading

RooobinYe commented Aug 20, 2024

Serein207 commented Aug 20, 2024 •

edited

Loading

RooobinYe commented Aug 22, 2024

github-actions bot commented Aug 22, 2024

RooobinYe commented Aug 23, 2024 •

edited

Loading

github-actions bot commented Aug 23, 2024

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

github-actions bot left a comment

github-actions bot Sep 5, 2024

feat(ui): finish about page #27

feat(ui): finish about page #27

Conversation

RooobinYe commented Aug 15, 2024 • edited Loading

RooobinYe commented Aug 15, 2024 • edited Loading

cEvolve05 commented Aug 15, 2024

ArcticLampyrid commented Aug 15, 2024

RooobinYe commented Aug 15, 2024

github-actions bot commented Aug 19, 2024

RooobinYe commented Aug 19, 2024 • edited Loading

RooobinYe commented Aug 19, 2024

github-actions bot commented Aug 19, 2024

Serein207 commented Aug 20, 2024 • edited Loading

github-actions bot commented Aug 20, 2024

github-actions bot commented Aug 20, 2024

RooobinYe commented Aug 20, 2024 • edited Loading

RooobinYe commented Aug 20, 2024

Serein207 commented Aug 20, 2024 • edited Loading

RooobinYe commented Aug 22, 2024

github-actions bot commented Aug 22, 2024

RooobinYe commented Aug 23, 2024 • edited Loading

github-actions bot commented Aug 23, 2024

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Sep 5, 2024

Choose a reason for hiding this comment

RooobinYe commented Aug 15, 2024 •

edited

Loading

RooobinYe commented Aug 15, 2024 •

edited

Loading

RooobinYe commented Aug 19, 2024 •

edited

Loading

Serein207 commented Aug 20, 2024 •

edited

Loading

RooobinYe commented Aug 20, 2024 •

edited

Loading

Serein207 commented Aug 20, 2024 •

edited

Loading

RooobinYe commented Aug 23, 2024 •

edited

Loading