[FIX] #10392 #2
Merged
[FIX] #10392 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please check pre-commit error and warnings: https://github.com/NL66278/web/actions/runs/8374877634/job/22931047156?pr=2 |
|
Maybe the original problem is caused by the fact that sale.order.report is based on a view, so no fields are to be saved?? Just guessing, no research.... |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
@NL66278 passing, green and tested on customer server. ready for merge. |
NL66278
merged commit 7a916a1
into
NL66278:14.0-web_advanced_search-select-dialog
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@NL66278 the error appearing was a missing
Error: Couldn't find method '_onLoadOptionalFields' in widget [object Object]
when using selecting ANY relational field "in selection" loading dialog.
this happens only on when searching on sale.report model records not on other models.
MR works and is trested, provides needed functions to the widget , wich were trivially implemented in 13.0 too, as a simple prevent propagation.