-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/aqm canopy #19
Draft
drnimbusrain
wants to merge
90
commits into
NOAA-EMC:develop
Choose a base branch
from
noaa-oar-arl:feature/aqm_canopy
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/rrfs cmaq canopy
Fixed Makefile.in typo.
seems was leftover when the new guarded one was merged in
was added by Youhua but is not present in upstream
upstream doesn't have it
Quick check of canopy inputs and photolysis attenuation factors.
Fixed bug on integrating though ZCAN=ZFL, and rolled back to FCH > 0.5 m canopy condition to be consistent with initial implementation.
Fixed bug on integrating though ZCAN=ZFL, and rolled back to FCH > 0.5 m canopy condition to be consistent with initial implementation.
Feature/aqm canopy
Co-authored-by: Patrick Campbell <[email protected]>
Co-authored-by: Patrick Campbell <[email protected]>
Co-authored-by: Patrick Campbell <[email protected]>
Feature/aqm canopy new
@drnimbusrain If there's still work ongoing, it might be helpful to change this to a draft PR until the work is ready. |
Modified contiguous canopy condition for FRT with the new canopy data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BrianCurtis-NOAA @JianpingHuang-NOAA @KaiWang-NOAA
This PR adds the inline canopy photolysis effects to AQM/Online-CMAQ, and references issue #16 , which provides some more information on the canopy photolysis effect.
Note that this is only an option and does not change results from the base configuration. When turned on, this option also only affects grid cells that are satisfy contiguous canopy conditions in the code.
Canopy inputs are added to the aqm.rc like any other external input sources. Required variables are the forest canopy height (FCH), forest fraction (FRT), clumping index (CLU), population density (POPU), leaf area index from ECCC (LAIE), and four in-canopy level specific cumulative LAI fractions (C1R, C2R, C3R, and C4R). I have created these canopy inputs based on collaboration with ECCC. The differences are both AQM and CMAQ specific.
I have created the canopy input files for Online-CMAQ at the RRFS_CONUScompact_13km and NA13km domains here on Hera: /scratch2/NCEPDEV/naqfc/RRFS_CMAQ/canopy/
Here are the example canopy additions to the aqm.rc template that should be added and then populated based on updated sample configuration files in UFS-SRW-App/online-cmaq for EMCs testing.
canopy_yn: true
canopy_type: canopy
canopy_format: netcdf
canopy_file: {{ aqm_rc_canopy_file_fp }}
canopy_frequency: static
canopy_species::
FCH 1.00000 FCH m
FRT 1.00000 FRT 1
CLU 1.00000 CLU 1
POPU 1.00000 POPU 10000_people/10km2
LAIE 1.00000 LAIE 1
C1R 1.00000 C1R 1
C2R 1.00000 C2R 1
C3R 1.00000 C3R 1
C4R 1.00000 C4R 1
::
These effects have been tested in both the offline NAQFC ("NACC-CMAQ") and Online-CMAQ for the RRFS_CONUScompact_13km domain during August 2019 on Hera. Results show improved model performance and reduced ozone overpredictions in regions of contiguous canopies. There are negligible impacts on summer PM2.5. Please see my DSRA/EMC presentation for results.
Also, I have tested the canopy photolysis codes in the latest workflow with latest EMC/AQM codes, and ran the model for a 6-hr engineering test over the target larger NA13km domain on WCOSS2. Engineering tests of the photolysis effect over the NA domain seem OK:
@chan-hoo If/when this PR is accepted, can we rework the UFS-SRW-App to eventually remove the --canopy option and the canopy specific workflow changes/options as the integrated/default? Thank you.