Quick indentation bugfix

[DavidNew-NOAA]

Title says it all

[DavidNew-NOAA]

I'm actually getting an error trying to run with this ob. Anyone know the deal with it? Can I just comment it out for the sake of develop not breaking?

[RussTreadon-NOAA]

Does the error look like the traceback reported in issue #1362?

[RussTreadon-NOAA]

@DavidNew-NOAA , the - abi_g16 line in parm/atm/jcb-prototype_3dvar.yaml.j2 has an extra space before the hyphen. I removed the extra space and 2024022400 gfs_atmanlinit ran to completion

hercules-login-4:/work/noaa/da/rtreadon/git/global-workflow/pr2992/sorc/gdas.cd/parm/atm$ git diff jcb-prototype_3dvar.yaml.j2
diff --git a/parm/atm/jcb-prototype_3dvar.yaml.j2 b/parm/atm/jcb-prototype_3dvar.yaml.j2
index 1975c1f..c90b747 100644
--- a/parm/atm/jcb-prototype_3dvar.yaml.j2
+++ b/parm/atm/jcb-prototype_3dvar.yaml.j2
@@ -29,4 +29,4 @@ observations:
 #  - satwnd.viirs_npp
 #  - scatwind_ascat_metop-a
 #  - snowcvr
-   - abi_g16
+  - abi_g16

[RussTreadon-NOAA]

This change works.

[DavidNew-NOAA]

@RussTreadon-NOAA My PR adds that space and indeed that atmanlinit job runs to completion, but that atmanlvar job fails now

[DavidNew-NOAA]

@RussTreadon-NOAA I don't have the output in front of me right now. I'll have to look later, but it's related to that particular ob

[RussTreadon-NOAA]

2024022400 gfs_atmanlvar failed because abi_g16 bias correction files are not present in the job run directory. The radiance bias correction tarball for g-w CI C96C48_ufs_hybatmDA only contains bias correction files for atms_n20 and atms_npp.

Two options:

1. comment out abi_g16 in parm/atm/jcb-prototype_3dvar.yaml.j2
2. add abi_g16 radiance correction files to g-w $ICSDIR/C96C48/gdas.20240223/18/analysis/atmos/gdas.t18z.rad_varbc_params.tar

[CoryMartin-NOAA]

why does it fail? JEDI crashes or something else? I would think that if the BC files are missing, it should run with no BC the first cycle, right? How would we spin up BC on a new sensor?

[RussTreadon-NOAA]

I don't think JEDI currently has the ability to spin up radiance bias correction files. Is this true, @emilyhcliu ?

[DavidNew-NOAA]

@RussTreadon-NOAA @CoryMartin-NOAA Given the moderate complexity of this question, I would say let's just comment out that ob so develop continues to work and make a separate issue.

[RussTreadon-NOAA]

I agree. If you can push this change (comment out abi_g16) I'll approve and we can merge.

[RussTreadon-NOAA]

Approve

[DavidNew-NOAA]

See GDASApp issue #1364