Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the manual operation of the marine verification tool #1373

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

apchoiCMD
Copy link
Collaborator

@apchoiCMD apchoiCMD commented Nov 13, 2024

This PR enables the Marine Verification Tool to run outside of the g-w CI workflow by submitting an sbatch job manually on Hera

Includes,

Most up-to-date plots can be found at

/scratch1/NCEPDEV/da/Mindo.Choi/sandbox/marine_vrfy/gdas.20210827/00/analysis/ocean/vrfy_final_PR

The wall time is as follows:

[Mindo.Choi@hfe02 vrfy]$ sacct -j 2477688 --format=JobID,JobName,State,ExitCode,Elapsed
JobID           JobName      State ExitCode    Elapsed
------------ ---------- ---------- -------- ----------
2477688      marine_vr+  COMPLETED      0:0   00:11:54
2477688.bat+      batch  COMPLETED      0:0   00:11:54
2477688.ext+     extern  COMPLETED      0:0   00:11:54

Additional plotting work will be added by consolidating vrfy task as follows:

  • SST/SSH time series
  • Omb time series
  • Spatial SSH/SST/OHC
  • HTML (?)

Close #1314 , Close #1345 , Close #1349

Copy link
Collaborator

@JohnSteffen-NOAA JohnSteffen-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @apchoiCMD .
Let's move the new scripts out of scripts/, maybe put them inside of utils/soca/fig_gallery?

scripts/exgdas_global_marine_analysis_vrfy_manual.py Outdated Show resolved Hide resolved
scripts/old/exgdas_global_marine_analysis_vrfy.py Outdated Show resolved Hide resolved
scripts/run_marine_analysis_vrfy_manual.job Outdated Show resolved Hide resolved
@apchoiCMD
Copy link
Collaborator Author

Thanks @apchoiCMD . Let's move the new scripts out of scripts/, maybe put them inside of utils/soca/fig_gallery?

Agree!

@apchoiCMD apchoiCMD marked this pull request as ready for review November 14, 2024 01:04
Copy link
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and useful

try:
ax.coastlines() # TODO: make this work on hpc
except Exception as e:
print(f"Warning: could not add coastlines. {e}")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants