Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to build and run on Orion Rocky 9 #764

Merged

Conversation

RussTreadon-NOAA
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA commented Jun 26, 2024

Description
This PR updates NOAA-EMC/GSI to build and run on Orion Rocky 9.

Resolves #754

Type of change

  • Maintenance

How Has This Been Tested?
Install on Orion and run ctests with results (all tests Passed) posted in issue #754.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • New and existing tests pass with my changes

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Jun 26, 2024
@RussTreadon-NOAA
Copy link
Contributor Author

Open PR in draft mode given increased wall times observed for gsi.x and enkf.x when run on Orion Rocky 9.

@RussTreadon-NOAA
Copy link
Contributor Author

Slowness of gsi.x and enkf.x on Orion Rocky 9 remains unexplained but will change this PR to Ready for review to invite feedback on proposed changes.

Copy link
Collaborator

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Hopefully between spack-stack developers and Orion admins we can sort out the slowdown on Orion.

@RussTreadon-NOAA
Copy link
Contributor Author

Agreed, @DavidHuber-NOAA ! The gsi.x and enkf.x slowdown on Orion Rocky 9 does not make sense to me.

@aerorahul
Copy link
Contributor

@RussTreadon-NOAA
Can this PR be merged with the knowledge that GSI is running in degraded status on Orion?
This will allow the global-workflow to proceed for Orion+Rocky8.
When the source of the degradation is identified on Orion, we can update the submodule pointer for Orion+Rocky8

Tagging @CatherineThomas-NOAA for awareness and discussions on the GFSv17 project tag-up.

@RussTreadon-NOAA
Copy link
Contributor Author

@aerorahul , let me check with the GSI Review team

@ShunLiu-NOAA , @CoryMartin-NOAA , and @hu5970 : Are we OK merging this PR into GSI develop even though ctests show gsi.x and enkf.x run approximately 2x slower on Orion Rocky 9 and Orion Centos 7? @aerorahul explains above why this question is being asked.

I'm reluctant to merge since do so may lessen the urgency of addressing the 2x slowdown. That said, we don't want NOAA-EMC/GSI to become the roadblock for completion of the g-w transition to Orion Rocky 9 (see issue #2694)

@CoryMartin-NOAA
Copy link
Contributor

@RussTreadon-NOAA I share your concerns but I don't think we have a choice. It's either "runs slow" or "not at all", so I think we have to go with the former.

@aerorahul
Copy link
Contributor

@aerorahul , let me check with the GSI Review team

@ShunLiu-NOAA , @CoryMartin-NOAA , and @hu5970 : Are we OK merging this PR into GSI develop even though ctests show gsi.x and enkf.x run approximately 2x slower on Orion Rocky 9 and Orion Centos 7? @aerorahul explains above why this question is being asked.

I'm reluctant to merge since do so may lessen the urgency of addressing the 2x slowdown. That said, we don't want NOAA-EMC/GSI to become the roadblock for completion of the g-w transition to Orion Rocky 9 (see issue #2694)

Just open another issue to report the performance degradation on Orion after the upgrade and follow the development there.

@RussTreadon-NOAA
Copy link
Contributor Author

Actions already taken reporting gsi.x and enkf.x slowdown on Orion Rocky-9:

  • open ticket RDHPCS ticket #2024062754000098 with Orion Helpdesk
  • open spack-stack issue #1166

Someone will need to follow up on the ticket and issue. doing so will likely require trying various things until the problem is resolved.

@RussTreadon-NOAA RussTreadon-NOAA merged commit 529bb79 into NOAA-EMC:develop Jun 28, 2024
4 checks passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/orion_rocky9 branch July 1, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Orion build to Rocky 9
4 participants