Update for g2_gribend.c #479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well that did go so well. Reworking... |
|
@edwardhartnett I have come to the conclusion that this we will need more complex code changes to check for this. Let's delete this PR and table to fix for 1.10. Apologies for not making this a draft PR first. |
EricEngle-NOAA
force-pushed
the
develop
branch
from
e35daf2 to
d76d557
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a rare condition in which the last 4 bytes of a packed section 7 could equal "7777" which is the GRIB end of message terminating string and triggers an erroneous end of message status.
The added logic checks for "7777" at the end of cgrib under the condition that we have a valid GRIB message through seciton 7.
This commit references #438