Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the mpas plotting scripts #174

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

delippi
Copy link
Collaborator

@delippi delippi commented Sep 17, 2024

Updated the mpas plotting scripts (the domain check also has plotting script built in) to correctly plot mpas domain edges. Prior to this update the concave boundaries would be filled by the plotting routines incorrectly leading to potential misinterpretation of data. The scripts were also cleaned up a little.

This fixes the following issue: #173

… script built in) to correctly plot mpas domain edges. Prior to this update the concave boundaries would be filled by the plotting routines incorrectly leading to potential misinterpretation of data.
ShunLiu-NOAA
ShunLiu-NOAA previously approved these changes Sep 17, 2024
Copy link

@ShunLiu-NOAA ShunLiu-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for the update.

@SamuelDegelia-NOAA
Copy link
Contributor

Nice solution @delippi. It looks like these python scripts assume "mpasout" files for the backgrounds. Do you want to hold off on merging this until #161 is merged? Also out of curiousity, what is reason for the difference in the increment vs. spread plots where the latter uses the extra tri.simplices argument in the Triangulation function?

@delippi
Copy link
Collaborator Author

delippi commented Sep 17, 2024

Nice solution @delippi. It looks like these python scripts assume "mpasout" files for the backgrounds. Do you want to hold off on merging this until #161 is merged? Also out of curiousity, what is reason for the difference in the increment vs. spread plots where the latter uses the extra tri.simplices argument in the Triangulation function?

Good catch. That was not needed. I will update accordingly. That just allowed you to specify the triangulation. It works fine without that option.

@guoqing-noaa
Copy link
Collaborator

@delippi Maybe you can change "mpasout" back to "restart" and test it with the latest RDASApp?
PR #161 will need more time to investigate. We would like to get your PR merged first.

@delippi
Copy link
Collaborator Author

delippi commented Sep 18, 2024

@SamuelDegelia-NOAA & @guoqing-noaa, I've reverted to the use of restart.nc instead of mpasout.nc and checked that it still works.

@ShunLiu-NOAA ShunLiu-NOAA merged commit 22c7702 into NOAA-EMC:develop Sep 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants