Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python converter for EFCLAM BUFR DUMP Data #213

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

PraveenKumar-NOAA
Copy link
Contributor

This PR adds a Python converter for EFCLAM BUFR DUMP data.

The converter will be used to transform EFCLAM BUFR data into IODA (netCDF) format. Following steps similar to GDASApp, a Python file and a JSON description file were created.

The following two files are new:

~/IODA/python/bufr2ioda_efclam.py
~/IODA/python/bufr2ioda_efclam.json

Related issue: #205

Validation for the output observation and IODA variable naming has been performed.

@SamuelDegelia-NOAA
Copy link
Contributor

Hi @PraveenKumar-NOAA, do you happen to have a sample efclam bufr file that we can use with this PR? I believe I have the lghtng data to test #212.

@PraveenKumar-NOAA
Copy link
Contributor Author

Hi @PraveenKumar-NOAA, do you happen to have a sample efclam bufr file that we can use with this PR? I believe I have the lghtng data to test #212.

@SamuelDegelia-NOAA there is no efclam data file in the RRFS test data, hence I used an RTMA file to validate the converter. I can send you this file or you are welcome to pick any efclam bufr file to test the converter.

@SamuelDegelia-NOAA
Copy link
Contributor

Could you send me the RTMA file? I do not have any other bufr files with efclam data at the moment. Thanks!

@PraveenKumar-NOAA
Copy link
Contributor Author

Could you send me the RTMA file? I do not have any other bufr files with efclam data at the moment. Thanks!

@SamuelDegelia-NOAA please use this file from Hercules - /work2/noaa/da/pkumar/dump/rtma.t00z.efclam.tm00.bufr_d

Copy link
Contributor

@SamuelDegelia-NOAA SamuelDegelia-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PraveenKumar-NOAA, this converter works well for me too!

As an aside for any other reviewers, we need to make 1-2 small changes to the code here to test the converters inside RDASApp. This is because of how we name the staged bufr/prepbufr files for our MPAS test case. But these converters are meant to be general and file names might change in the workflow. So this behavior is expected for the current status of RDASApp.

Copy link
Collaborator

@delippi delippi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took a little bit to figure out what needed changed for the generic setup to work with our staged data, but wasn't too difficult. One thing I noticed was that the DUMP variable doesn't seem to be used in the run_bufr2ioda.sh that is in the wiki instructions, but instead uses cycle_type in the .json file. I think this is a good base to easily make updates for specific use in the workflow.

@hu5970 hu5970 merged commit 47b9fc8 into develop Nov 7, 2024
3 checks passed
@hu5970 hu5970 deleted the feature/efclam_python branch November 7, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants