Skip to content

Commit

Permalink
revert GFS f-o changes related to app=S2SWA
Browse files Browse the repository at this point in the history
  • Loading branch information
aerorahul committed Jul 11, 2024
1 parent ec60311 commit 5fc2193
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 14 deletions.
6 changes: 0 additions & 6 deletions workflow/applications/applications.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,18 +79,12 @@ def __init__(self, conf: Configuration) -> None:
self.wave_cdumps = [wave_cdump]

self.aero_anl_cdumps = None
self.aero_fcst_cdumps = None
if self.do_aero:
aero_anl_cdump = _base.get('AERO_ANL_CDUMP', 'BOTH').lower()
if aero_anl_cdump in ['both']:
self.aero_anl_cdumps = ['gfs', 'gdas']
elif aero_anl_cdump in ['gfs', 'gdas']:
self.aero_anl_cdumps = [aero_anl_cdump]
aero_fcst_cdump = _base.get('AERO_FCST_CDUMP', None).lower()
if aero_fcst_cdump in ['both']:
self.aero_fcst_cdumps = ['gfs', 'gdas']
elif aero_fcst_cdump in ['gfs', 'gdas']:
self.aero_fcst_cdumps = [aero_fcst_cdump]

def _init_finalize(self, conf: Configuration):
print("Finalizing initialize")
Expand Down
8 changes: 3 additions & 5 deletions workflow/applications/gfs_forecast_only.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ def _get_app_configs(self):
configs += ['atmos_products']

if self.do_aero:
if self._base['EXP_WARM_START'] in ['.false.']:
configs += ['aerosol_init']
configs += ['aerosol_init']

if self.do_tracker:
configs += ['tracker']
Expand Down Expand Up @@ -88,10 +87,9 @@ def get_task_names(self):
tasks = ['stage_ic']

if self.do_aero:
aero_fcst_cdump = self._base.get('AERO_FCST_CDUMP', 'BOTH').lower()
aero_fcst_cdump = _base.get('AERO_FCST_CDUMP', 'BOTH').lower()
if self._base['CDUMP'] in aero_fcst_cdump or aero_fcst_cdump == "both":
if self._base['EXP_WARM_START'] in ['.false.']:
tasks += ['aerosol_init']
tasks += ['aerosol_init']

if self.do_wave:
tasks += ['waveinit']
Expand Down
4 changes: 1 addition & 3 deletions workflow/rocoto/gfs_tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -856,9 +856,7 @@ def _fcst_forecast_only(self):
dep_dict = {'type': 'task', 'name': f'{self.cdump}{wave_job}'}
dependencies.append(rocoto.add_dependency(dep_dict))

if self.app_config.do_aero and \
self.cdump in self.app_config.aero_fcst_cdumps and \
self._base['EXP_WARM_START'] in ['.false.']:
if self.app_config.do_aero and self.cdump in self.app_config.aero_fcst_cdumps:
# Calculate offset based on CDUMP = gfs | gdas
interval = None
if self.cdump in ['gfs']:
Expand Down

0 comments on commit 5fc2193

Please sign in to comment.