Skip to content

Commit

Permalink
few shell norms
Browse files Browse the repository at this point in the history
  • Loading branch information
TerryMcGuinness-NOAA committed Jun 5, 2024
1 parent 3c9bb58 commit c7282dc
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions ci/scripts/tests/run_setup_xml.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

output="testdata/output.txt"

rm -f $output
rm -f "${output}"
export ACCOUNT=foo
echo "ACCOUNT=$ACCOUNT" > $output

Check notice

Code scanning / shellcheck

Prefer putting braces around variable references even when not strictly required. Note test

Prefer putting braces around variable references even when not strictly required.

Check notice

Code scanning / shellcheck

Prefer double quoting even when variables don't contain special characters. Note test

Prefer double quoting even when variables don't contain special characters.

Check notice

Code scanning / shellcheck

Prefer putting braces around variable references even when not strictly required. Note test

Prefer putting braces around variable references even when not strictly required.

../../../workflow/setup_xml.py $1
../../../workflow/setup_xml.py "${1}"

0 comments on commit c7282dc

Please sign in to comment.