Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate BASE_CPLIC by platform #1715

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Consolidate BASE_CPLIC by platform #1715

merged 2 commits into from
Jun 27, 2023

Conversation

aerorahul
Copy link
Contributor

@aerorahul aerorahul commented Jun 26, 2023 •
edited
Loading

Description
BASE_CPLIC depends on the machine. It is now defined in hosts/machine.yaml together with other machine specific paths.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
CI tests although only coupled forecast-only test is impacted and necessary.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

@aerorahul aerorahul added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion labels Jun 26, 2023
WalterKolczynski-NOAA
WalterKolczynski-NOAA approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending CI. Good improvement.

@emcbot emcbot added CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress and removed CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion labels Jun 26, 2023
@emcbot
Copy link

emcbot commented Jun 26, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Mon Jun 26 16:36:18 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Mon Jun 26 16:38:12 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Mon Jun 26 17:56:33 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 17:56:39 CDT 2023 for experiment C48_S2S
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 17:56:44 CDT 2023 for experiment C96_atm3DVar
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 17:56:47 CDT 2023 for experiment C96C48_hybatmDA

@emcbot emcbot added CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Jun 26, 2023
@emcbot
Copy link

emcbot commented Jun 26, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Mon Jun 26 21:37:00 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Mon Jun 26 21:42:57 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Mon Jun 26 22:57:26 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 22:57:31 UTC 2023 for experiment C48_S2S
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 22:57:35 UTC 2023 for experiment C96C48_hybatmDA
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 22:57:38 UTC 2023 for experiment C96_atm3DVar

@emcbot
Copy link

emcbot commented Jun 26, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Mon Jun 26 16:36:18 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Mon Jun 26 16:38:12 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Mon Jun 26 17:56:33 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 17:56:39 CDT 2023 for experiment C48_S2S
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 17:56:44 CDT 2023 for experiment C96_atm3DVar
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 17:56:47 CDT 2023 for experiment C96C48_hybatmDA
Experiment C48_S2S completed: *SUCCESS*
Experiment C48_S2S Completed at Mon Jun 26 18:33:06 CDT 2023
with 18 successfully completed jobs

@emcbot
Copy link

emcbot commented Jun 27, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Mon Jun 26 21:37:00 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Mon Jun 26 21:42:57 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Mon Jun 26 22:57:26 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 22:57:31 UTC 2023 for experiment C48_S2S
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 22:57:35 UTC 2023 for experiment C96C48_hybatmDA
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 22:57:38 UTC 2023 for experiment C96_atm3DVar
Experiment C48_S2S completed: *SUCCESS*
Experiment C48_S2S Completed at Tue Jun 27 00:57:11 UTC 2023
with 18 successfully completed jobs

@emcbot
Copy link

emcbot commented Jun 27, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Mon Jun 26 16:36:18 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Mon Jun 26 16:38:12 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Mon Jun 26 17:56:33 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 17:56:39 CDT 2023 for experiment C48_S2S
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 17:56:44 CDT 2023 for experiment C96_atm3DVar
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 17:56:47 CDT 2023 for experiment C96C48_hybatmDA
Experiment C48_S2S completed: *SUCCESS*
Experiment C48_S2S Completed at Mon Jun 26 18:33:06 CDT 2023
with 18 successfully completed jobs
Experiment C96_atm3DVar completed: *SUCCESS*
Experiment C96_atm3DVar Completed at Mon Jun 26 20:06:06 CDT 2023
with 86 successfully completed jobs

@emcbot
Copy link

emcbot commented Jun 27, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Mon Jun 26 16:36:18 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Mon Jun 26 16:38:12 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Mon Jun 26 17:56:33 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 17:56:39 CDT 2023 for experiment C48_S2S
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 17:56:44 CDT 2023 for experiment C96_atm3DVar
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 17:56:47 CDT 2023 for experiment C96C48_hybatmDA
Experiment C48_S2S completed: *SUCCESS*
Experiment C48_S2S Completed at Mon Jun 26 18:33:06 CDT 2023
with 18 successfully completed jobs
Experiment C96_atm3DVar completed: *SUCCESS*
Experiment C96_atm3DVar Completed at Mon Jun 26 20:06:06 CDT 2023
with 86 successfully completed jobs
Experiment C96C48_hybatmDA completed: *SUCCESS*
Experiment C96C48_hybatmDA Completed at Mon Jun 26 20:33:12 CDT 2023
with 148 successfully completed jobs

@emcbot emcbot added CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully and removed CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress labels Jun 27, 2023
@emcbot
Copy link

emcbot commented Jun 27, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Mon Jun 26 16:36:18 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Mon Jun 26 16:38:12 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Mon Jun 26 17:56:33 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 17:56:39 CDT 2023 for experiment C48_S2S
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 17:56:44 CDT 2023 for experiment C96_atm3DVar
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 17:56:47 CDT 2023 for experiment C96C48_hybatmDA
Experiment C48_S2S completed: *SUCCESS*
Experiment C48_S2S Completed at Mon Jun 26 18:33:06 CDT 2023
with 18 successfully completed jobs
Experiment C96_atm3DVar completed: *SUCCESS*
Experiment C96_atm3DVar Completed at Mon Jun 26 20:06:06 CDT 2023
with 86 successfully completed jobs
Experiment C96C48_hybatmDA completed: *SUCCESS*
Experiment C96C48_hybatmDA Completed at Mon Jun 26 20:33:12 CDT 2023
with 148 successfully completed jobs

@emcbot
Copy link

emcbot commented Jun 27, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Mon Jun 26 21:37:00 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Mon Jun 26 21:42:57 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Mon Jun 26 22:57:26 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 22:57:31 UTC 2023 for experiment C48_S2S
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 22:57:35 UTC 2023 for experiment C96C48_hybatmDA
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 22:57:38 UTC 2023 for experiment C96_atm3DVar
Experiment C48_S2S completed: *SUCCESS*
Experiment C48_S2S Completed at Tue Jun 27 00:57:11 UTC 2023
with 18 successfully completed jobs
Experiment C96C48_hybatmDA completed: *SUCCESS*
Experiment C96C48_hybatmDA Completed at Tue Jun 27 03:06:14 UTC 2023
with 148 successfully completed jobs

@emcbot
Copy link

emcbot commented Jun 27, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Mon Jun 26 21:37:00 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Mon Jun 26 21:42:57 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Mon Jun 26 22:57:26 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 22:57:31 UTC 2023 for experiment C48_S2S
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 22:57:35 UTC 2023 for experiment C96C48_hybatmDA
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 22:57:38 UTC 2023 for experiment C96_atm3DVar
Experiment C48_S2S completed: *SUCCESS*
Experiment C48_S2S Completed at Tue Jun 27 00:57:11 UTC 2023
with 18 successfully completed jobs
Experiment C96C48_hybatmDA completed: *SUCCESS*
Experiment C96C48_hybatmDA Completed at Tue Jun 27 03:06:14 UTC 2023
with 148 successfully completed jobs
Experiment C96_atm3DVar completed: *SUCCESS*
Experiment C96_atm3DVar Completed at Tue Jun 27 04:06:12 UTC 2023
with 86 successfully completed jobs

@emcbot emcbot added CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Jun 27, 2023
@emcbot
Copy link

emcbot commented Jun 27, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Mon Jun 26 21:37:00 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Mon Jun 26 21:42:57 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Mon Jun 26 22:57:26 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 22:57:31 UTC 2023 for experiment C48_S2S
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 22:57:35 UTC 2023 for experiment C96C48_hybatmDA
Created experiment:            *SUCCESS*
Case setup: Completed at Mon Jun 26 22:57:38 UTC 2023 for experiment C96_atm3DVar
Experiment C48_S2S completed: *SUCCESS*
Experiment C48_S2S Completed at Tue Jun 27 00:57:11 UTC 2023
with 18 successfully completed jobs
Experiment C96C48_hybatmDA completed: *SUCCESS*
Experiment C96C48_hybatmDA Completed at Tue Jun 27 03:06:14 UTC 2023
with 148 successfully completed jobs
Experiment C96_atm3DVar completed: *SUCCESS*
Experiment C96_atm3DVar Completed at Tue Jun 27 04:06:12 UTC 2023
with 86 successfully completed jobs

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit ae56219 into NOAA-EMC:develop Jun 27, 2023
8 checks passed
@aerorahul aerorahul deleted the feature/coupled_ic branch June 27, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

Assignees
No one assigned
Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aerorahul @emcbot @WalterKolczynski-NOAA