Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move nems.configure templates to parm/ufs #1737

Merged
merged 6 commits into from
Jul 14, 2023
Merged

Move nems.configure templates to parm/ufs #1737

merged 6 commits into from
Jul 14, 2023

Conversation

aerorahul
Copy link
Contributor

Description
This PR:

  • moves nems.configure.*.IN templates from ush to parm/ufs.
  • uses atparse.bash from the ufs-weather-model to fill those templates.
  • make gefs/config.resources in WW3 same as in gfs/config.resources.
  • makes use of HOMEgfs instead of SCRIPTDIR and script_dir local variables that are unnecessary aliases and make code understanding easier.
  • initializes PETS to 0 and then sets the right value if that component is enabled.

A follow-up PR will reconcile the templates and use them directly from the ufs-weather-model. Several differences were noticed between the ones in global-workflow and ufs-weather-model and help may be needed from @junwang-noaa to update the ufs-weather-model (if required).

Fixes: #1599

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • ran coupled (S2S) and atm-only forecast. Both ran to completion successfully.
  • This file has no bearing on warm or cold starts.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 13, 2023
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shellcheck found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@WalterKolczynski-NOAA
Copy link
Contributor

Try changing external-sources to true in .shellcheckrc to see if it clears up these 'not used' warnings.

@aerorahul aerorahul added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion labels Jul 13, 2023
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Jul 13, 2023
@emcbot
Copy link

emcbot commented Jul 13, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Thu Jul 13 21:40:29 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Jul 13 21:46:49 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Thu Jul 13 22:14:42 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 22:14:48 UTC 2023 for experiment C48_S2S_e0bd484c
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 22:14:52 UTC 2023 for experiment C96C48_hybatmDA_e0bd484c
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 22:14:55 UTC 2023 for experiment C96_atm3DVar_e0bd484c

@emcbot emcbot added CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress and removed CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion labels Jul 13, 2023
@emcbot
Copy link

emcbot commented Jul 13, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Thu Jul 13 16:40:37 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Jul 13 16:42:33 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Thu Jul 13 17:16:28 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 17:16:40 CDT 2023 for experiment C48_S2S_e0bd484c
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 17:16:44 CDT 2023 for experiment C96_atm3DVar_e0bd484c
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 17:16:50 CDT 2023 for experiment C96C48_hybatmDA_e0bd484c

@emcbot
Copy link

emcbot commented Jul 13, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Thu Jul 13 16:40:37 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Jul 13 16:42:33 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Thu Jul 13 17:16:28 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 17:16:40 CDT 2023 for experiment C48_S2S_e0bd484c
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 17:16:44 CDT 2023 for experiment C96_atm3DVar_e0bd484c
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 17:16:50 CDT 2023 for experiment C96C48_hybatmDA_e0bd484c
Experiment C48_S2S_e0bd484c completed: *SUCCESS*
Experiment C48_S2S_e0bd484c Completed at Thu Jul 13 18:00:35 CDT 2023
with 18 successfully completed jobs

@emcbot
Copy link

emcbot commented Jul 13, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Thu Jul 13 21:40:29 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Jul 13 21:46:49 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Thu Jul 13 22:14:42 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 22:14:48 UTC 2023 for experiment C48_S2S_e0bd484c
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 22:14:52 UTC 2023 for experiment C96C48_hybatmDA_e0bd484c
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 22:14:55 UTC 2023 for experiment C96_atm3DVar_e0bd484c
Experiment C48_S2S_e0bd484c completed: *SUCCESS*
Experiment C48_S2S_e0bd484c Completed at Thu Jul 13 23:51:15 UTC 2023
with 18 successfully completed jobs

@emcbot
Copy link

emcbot commented Jul 14, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Thu Jul 13 16:40:37 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Jul 13 16:42:33 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Thu Jul 13 17:16:28 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 17:16:40 CDT 2023 for experiment C48_S2S_e0bd484c
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 17:16:44 CDT 2023 for experiment C96_atm3DVar_e0bd484c
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 17:16:50 CDT 2023 for experiment C96C48_hybatmDA_e0bd484c
Experiment C48_S2S_e0bd484c completed: *SUCCESS*
Experiment C48_S2S_e0bd484c Completed at Thu Jul 13 18:00:35 CDT 2023
with 18 successfully completed jobs
Experiment C96_atm3DVar_e0bd484c completed: *SUCCESS*
Experiment C96_atm3DVar_e0bd484c Completed at Thu Jul 13 19:36:12 CDT 2023
with 86 successfully completed jobs

@emcbot
Copy link

emcbot commented Jul 14, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Thu Jul 13 16:40:37 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Jul 13 16:42:33 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Thu Jul 13 17:16:28 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 17:16:40 CDT 2023 for experiment C48_S2S_e0bd484c
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 17:16:44 CDT 2023 for experiment C96_atm3DVar_e0bd484c
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 17:16:50 CDT 2023 for experiment C96C48_hybatmDA_e0bd484c
Experiment C48_S2S_e0bd484c completed: *SUCCESS*
Experiment C48_S2S_e0bd484c Completed at Thu Jul 13 18:00:35 CDT 2023
with 18 successfully completed jobs
Experiment C96_atm3DVar_e0bd484c completed: *SUCCESS*
Experiment C96_atm3DVar_e0bd484c Completed at Thu Jul 13 19:36:12 CDT 2023
with 86 successfully completed jobs
Experiment C96C48_hybatmDA_e0bd484c completed: *SUCCESS*
Experiment C96C48_hybatmDA_e0bd484c Completed at Thu Jul 13 20:26:08 CDT 2023
with 148 successfully completed jobs

@emcbot emcbot added CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully and removed CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress labels Jul 14, 2023
@emcbot
Copy link

emcbot commented Jul 14, 2023

Automated global-workflow Testing Results:

Machine: Orion
Start: Thu Jul 13 16:40:37 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Jul 13 16:42:33 CDT 2023
Build:                         *SUCCESS*
Build: Completed at Thu Jul 13 17:16:28 CDT 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 17:16:40 CDT 2023 for experiment C48_S2S_e0bd484c
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 17:16:44 CDT 2023 for experiment C96_atm3DVar_e0bd484c
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 17:16:50 CDT 2023 for experiment C96C48_hybatmDA_e0bd484c
Experiment C48_S2S_e0bd484c completed: *SUCCESS*
Experiment C48_S2S_e0bd484c Completed at Thu Jul 13 18:00:35 CDT 2023
with 18 successfully completed jobs
Experiment C96_atm3DVar_e0bd484c completed: *SUCCESS*
Experiment C96_atm3DVar_e0bd484c Completed at Thu Jul 13 19:36:12 CDT 2023
with 86 successfully completed jobs
Experiment C96C48_hybatmDA_e0bd484c completed: *SUCCESS*
Experiment C96C48_hybatmDA_e0bd484c Completed at Thu Jul 13 20:26:08 CDT 2023
with 148 successfully completed jobs

@emcbot
Copy link

emcbot commented Jul 14, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Thu Jul 13 21:40:29 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Jul 13 21:46:49 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Thu Jul 13 22:14:42 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 22:14:48 UTC 2023 for experiment C48_S2S_e0bd484c
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 22:14:52 UTC 2023 for experiment C96C48_hybatmDA_e0bd484c
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 22:14:55 UTC 2023 for experiment C96_atm3DVar_e0bd484c
Experiment C48_S2S_e0bd484c completed: *SUCCESS*
Experiment C48_S2S_e0bd484c Completed at Thu Jul 13 23:51:15 UTC 2023
with 18 successfully completed jobs
Experiment C96C48_hybatmDA_e0bd484c completed: *SUCCESS*
Experiment C96C48_hybatmDA_e0bd484c Completed at Fri Jul 14 03:21:10 UTC 2023
with 148 successfully completed jobs

@emcbot
Copy link

emcbot commented Jul 14, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Thu Jul 13 21:40:29 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Jul 13 21:46:49 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Thu Jul 13 22:14:42 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 22:14:48 UTC 2023 for experiment C48_S2S_e0bd484c
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 22:14:52 UTC 2023 for experiment C96C48_hybatmDA_e0bd484c
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 22:14:55 UTC 2023 for experiment C96_atm3DVar_e0bd484c
Experiment C48_S2S_e0bd484c completed: *SUCCESS*
Experiment C48_S2S_e0bd484c Completed at Thu Jul 13 23:51:15 UTC 2023
with 18 successfully completed jobs
Experiment C96C48_hybatmDA_e0bd484c completed: *SUCCESS*
Experiment C96C48_hybatmDA_e0bd484c Completed at Fri Jul 14 03:21:10 UTC 2023
with 148 successfully completed jobs
Experiment C96_atm3DVar_e0bd484c completed: *SUCCESS*
Experiment C96_atm3DVar_e0bd484c Completed at Fri Jul 14 03:27:15 UTC 2023
with 86 successfully completed jobs

@emcbot emcbot added CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Jul 14, 2023
@emcbot
Copy link

emcbot commented Jul 14, 2023

Automated global-workflow Testing Results:

Machine: Hera
Start: Thu Jul 13 21:40:29 UTC 2023 on hfe05
---------------------------------------------------
Checkout:                      *SUCCESS*
Checkout: Completed at Thu Jul 13 21:46:49 UTC 2023
Build:                         *SUCCESS*
Build: Completed at Thu Jul 13 22:14:42 UTC 2023
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 22:14:48 UTC 2023 for experiment C48_S2S_e0bd484c
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 22:14:52 UTC 2023 for experiment C96C48_hybatmDA_e0bd484c
Created experiment:            *SUCCESS*
Case setup: Completed at Thu Jul 13 22:14:55 UTC 2023 for experiment C96_atm3DVar_e0bd484c
Experiment C48_S2S_e0bd484c completed: *SUCCESS*
Experiment C48_S2S_e0bd484c Completed at Thu Jul 13 23:51:15 UTC 2023
with 18 successfully completed jobs
Experiment C96C48_hybatmDA_e0bd484c completed: *SUCCESS*
Experiment C96C48_hybatmDA_e0bd484c Completed at Fri Jul 14 03:21:10 UTC 2023
with 148 successfully completed jobs
Experiment C96_atm3DVar_e0bd484c completed: *SUCCESS*
Experiment C96_atm3DVar_e0bd484c Completed at Fri Jul 14 03:27:15 UTC 2023
with 86 successfully completed jobs

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 3520bcb into NOAA-EMC:develop Jul 14, 2023
@aerorahul aerorahul deleted the feature/nems_configure branch July 14, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

Assignees
No one assigned
Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move NEMS configure files to parm
3 participants
@aerorahul @WalterKolczynski-NOAA @emcbot