Change JEDI jobs to grab fieldmetadata from GDASApp rather than glopara fix #1739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoryMartin-NOAA
commented
Jul 14, 2023
| @@ -7,5 +7,5 @@ copy: | |||
| - !ENV ${DATA}/fv3jedi/fmsmpp.nml | |||
| - - !ENV ${FV3JEDI_FIX}/fv3jedi/fv3files/field_table_gfdl | |||
| - !ENV ${DATA}/fv3jedi/field_table | |||
| - - !ENV ${FV3JEDI_FIX}/fv3jedi/fieldmetadata/gfs-aerosol.yaml | |||
| - !ENV ${DATA}/fv3jedi/gfs-restart.yaml | |||
| - - !ENV $(HOMEgfs)/sorc/gdas.cd/parm/io/fv3jedi_fieldmetadata_restart.yaml | |||
There was a problem hiding this comment.
I'm guessing @aerorahul will want this to be instead linked at the link_workflow.sh stage and put somewhere else. Question is is that an 'eventually' thing or a 'now' thing?
There was a problem hiding this comment.
Correct. This should be linked to ${HOMEgfs}/parm/gdas/io/fv3jedi_fieldmetadata_restart.yaml in sorc/link_workflow.sh at the time the workflow is being setup for vertical structure.
From this location, it can be copied to DATA at job runtime.
There was a problem hiding this comment.
Per offline convo, Rahul and or I will do this, just not in this PR.
CoryMartin-NOAA
requested review from
aerorahul,
RussTreadon-NOAA and
WalterKolczynski-NOAA
aerorahul
reviewed
Jul 14, 2023
| @@ -4,4 +4,4 @@ copy: | |||
| - [$(HOMEgfs)/fix/gdas/fv3jedi/fv3files/akbk$(npz).nc4, $(DATA)/fv3jedi/akbk.nc4] | |||
| - [$(HOMEgfs)/fix/gdas/fv3jedi/fv3files/fmsmpp.nml, $(DATA)/fv3jedi/fmsmpp.nml] | |||
| - [$(HOMEgfs)/fix/gdas/fv3jedi/fv3files/field_table_gfdl, $(DATA)/fv3jedi/field_table] | |||
| - [$(HOMEgfs)/fix/gdas/fv3jedi/fieldmetadata/gfs-restart.yaml, $(DATA)/fv3jedi/gfs-restart.yaml] | |||
| - [$(HOMEgfs)/sorc/gdas.cd/parm/io/fv3jedi_fieldmetadata_restart.yaml, $(DATA)/fv3jedi/fv3jedi_fieldmetadata_restart.yaml] | |||
There was a problem hiding this comment.
same with this and others
aerorahul
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I think out of convenience before, the glopara/fix/gdas directories contain several text files that do not need to be maintained by the glopara group, and can instead store them in GDASApp or global-workflow.
This PR is the first step towards that, by moving the FV3-JEDI IO fieldmetadata files into GDASApp. Subsequent work will need to determine if things like FV3 diag tables can be shared between FV3-JEDI and the UFS.
This is a complimentary PR to NOAA-EMC/GDASApp#537
Before this can be merged, the above PR must be merged and this PR will need an updated GDASApp hash added in a commit.
Type of change
How Has This Been Tested?
Checklist