Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates ocean files in gdasarch #2594

Conversation

AndrewEichmann-NOAA
Copy link
Contributor

Description

Fixes bug where ocean history files are not archived.

Resolves NOAA-EMC/GDASApp#1105

Type of change

  • Bug fix (fixes something broken)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? YES
  • Does this change require a documentation update? NO

How has this been tested?

Not tested, would require cycling test. Will be tested in ongoing experiment

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • [] New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

@AndrewEichmann-NOAA AndrewEichmann-NOAA marked this pull request as ready for review May 13, 2024 15:11
@AndrewEichmann-NOAA
Copy link
Contributor Author

FYI @guillaumevernieres @KatherineLukens-NOAA Katie you can hand-patch this in to your build

Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 555 of hpssarch_gen.sh is also referencing the wrong directory for the MOM6 input namelist. It should be

echo "${COM_CONF/${ROTDIR}\//}/ufs.MOM_input"

Copy link

@KatherineLukens-NOAA KatherineLukens-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes were tested. They resolve the issue. Recommend merge.

@WalterKolczynski-NOAA
Copy link
Contributor

#2491 seems imminent. Do we need to deal with this immediately, or can we just wait for that?

@AndrewEichmann-NOAA
Copy link
Contributor Author

#2491 seems imminent. Do we need to deal with this immediately, or can we just wait for that?

I think we're ok - @KatherineLukens-NOAA patched manually.

@AndrewEichmann-NOAA
Copy link
Contributor Author

@CatherineThomas-NOAA @JessicaMeixner-NOAA Guillaume thought you might want to know about this

@JessicaMeixner-NOAA JessicaMeixner-NOAA mentioned this pull request May 14, 2024
13 tasks
@aerorahul
Copy link
Contributor

@DavidHuber-NOAA
Can you include the changes in this PR into #2621
The file that this PR is modifying no longer exists.

@DavidHuber-NOAA
Copy link
Contributor

@aerorahul This was actually captured in #2491 (here). There are some other ocean archiving issues I'm working through with @AndrewEichmann-NOAA and @guillaumevernieres in #2621, but they are separate from this particular PR, so I think this can be closed.

@aerorahul
Copy link
Contributor

OBE

@aerorahul aerorahul closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Archive ocean history files on HPSS
5 participants