-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates ocean files in gdasarch #2594
Updates ocean files in gdasarch #2594
Conversation
FYI @guillaumevernieres @KatherineLukens-NOAA Katie you can hand-patch this in to your build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 555 of hpssarch_gen.sh is also referencing the wrong directory for the MOM6 input namelist. It should be
echo "${COM_CONF/${ROTDIR}\//}/ufs.MOM_input"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes were tested. They resolve the issue. Recommend merge.
#2491 seems imminent. Do we need to deal with this immediately, or can we just wait for that? |
I think we're ok - @KatherineLukens-NOAA patched manually. |
@CatherineThomas-NOAA @JessicaMeixner-NOAA Guillaume thought you might want to know about this |
@DavidHuber-NOAA |
@aerorahul This was actually captured in #2491 (here). There are some other ocean archiving issues I'm working through with @AndrewEichmann-NOAA and @guillaumevernieres in #2621, but they are separate from this particular PR, so I think this can be closed. |
OBE |
Description
Fixes bug where ocean history files are not archived.
Resolves NOAA-EMC/GDASApp#1105
Type of change
Change characteristics
How has this been tested?
Not tested, would require cycling test. Will be tested in ongoing experiment
Checklist