Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STMP CI yaml over ride updates due to Orion-Hercules cross mounting #2613

Conversation

TerrenceMcGuinness-NOAA
Copy link
Collaborator

Description

This hot bug fix updates how CI over rides the STMP value for Hercules and Orion cases because they are cross mounted.

Also took this moment to update SLUM to BATCH because its a misnomer.

Type of change

  • Bug fix (fixes something broken)

We had to include the updating of STMP in the over ride yaml configs in CI because the value is designated in $HOMEgfs/workflow/hosts/$MACHINE_ID.yaml

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

Going to run CI on Orion/Hercules

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA added the CI/CD Issue related to CI/CD label May 21, 2024
@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion labels May 21, 2024
@emcbot emcbot added CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion and removed CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion labels May 21, 2024
@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA added CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules labels May 21, 2024
@emcbot
Copy link

emcbot commented May 21, 2024

Build FAILED on Orion with error logs:

/work2/noaa/stmp/CI/ORION/2613/gfs/sorc/logs/build_gsi_enkf.log

Follow link here to view the contents of the above file(s): (link)

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a suggested change in the name of the account

ci/cases/yamls/atmaerosnowDA_defaults_ci.yaml Show resolved Hide resolved
@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA added CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules labels May 21, 2024
@emcbot emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion labels May 21, 2024
Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we use it anywhere, but PTMP is also being set to a common directory for Orion and Hercules. Should that be added here as well?

@TerrenceMcGuinness-NOAA
Copy link
Collaborator Author

@WalterKolczynski-NOAA Dave is right, we added both in the shell, we should add it in the over rides too, right?

@emcbot emcbot added CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress and removed CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules labels May 21, 2024
@emcbot emcbot added CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully and removed CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress labels May 21, 2024
@emcbot
Copy link

emcbot commented May 21, 2024

CI Passed Orion at
Built and ran in directory /work2/noaa/stmp/CI/ORION/2613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Issue related to CI/CD CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants