-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HR4 GWD update #2670
HR4 GWD update #2670
Conversation
@Qingfu-Liu The changes in this PR look simple enough. Tests will be required to pass before we can merge this PR as it involves an update to the hash of the ufs-weather-model. |
@aerorahul Thank you very much. I am setting up a forecast only test. Once the test is complete, I will update this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do_gsl_drag_ss should be set to ".false" in config.fcst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"psl_gwd_z0m_factor" should be renamed as "gwd_z0m_factor" in config.fcst and parsing_namelists_FV3*.sh, to be consistent with that change in NoahMP codes.
@JongilHan66 Thank you very much. I saw this two days ago, but I am thinking to update it once the workflow test is successful. I still have problem to run the workflow tests since the input.nml does not match the namelist reading |
The changes of the NoahMP model (which are not used for HR4-GWD-update tests) have been retracted. All the regression tests are passed on Hera |
New ugwd fix version will be: 20240624 @Qingfu-Liu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to also add "export psl_gwd_dx_factor=6.0" after "export do_gwd_opt_psl=".true." line in config.fcst, so one can easily test the model with a different value of psl_gwd_dx_factor.
@JongilHan66 I think that means we're going to have to create a new PR building off this one (unless you have permissions on the branch to push updates). We'll need to update the model once the PR is merged and update the fix ver, so there will be other updates for that as well. |
@JessicaMeixner-NOAA If necessary, please create a new PR. |
@JessicaMeixner-NOAA If adding "export psl_gwd_dx_factor=6.0" in config.fcst requires a too much effort, I'd like to cancel my suggestion. |
@JongilHan66 I don't think it's a huge effort to add your suggestion. It would be great if someone from the physics team could take over this PR and make the suggestion you made as well as update the model and the fix ver. If no one from the physics team is available to do this, please let me know. |
@JessicaMeixner-NOAA I don't think we have someone from the physics team to take over this PR. |
@JongilHan66 I will take this over. |
@JessicaMeixner-NOAA Thanks very much, Jessica!! |
This PR is being closed and continued in #2732 |
Description
This PR#2670 depends on ufs-weather-model PR#2290 (waiting to merge), fv3atm PR#836 and ccpp-physics PR#207.
This update is a combination of the gravity wave drag (GWD) versions from the NOAA/GSL and NOAA/PSL
The test results with this update can be seen in:
a) summer: https://www.emc.ncep.noaa.gov/gmb/jhan/vsdbw/hr3e50s
b) winter: https://www.emc.ncep.noaa.gov/gmb/jhan/vsdbw/hr3d11w
HR4GWD: same as HR3 but with the updated GWD
Compared to the HR2 and HR3, the HR4GWD shows a significant improvement especially in 500mb height AC and CONUS precipitation forecast skills. The HR4GWD reduces the cold and dry biases in the lower troposphere compared to the HR3. It also reduces the negative wind speed biases in the troposphere compared to the HR2.
This PR#2670 includes changes for four scripts, and new orographic data.
The new orographic data temporarily stored at:
/scratch1/NCEPDEV/global/Qingfu.Liu/git/GWD_SHong/APR2023_SSO
and this new data should replace the old data: /scratch1/NCEPDEV/global/glopara/fix/ugwd/20231027
Refs NOAA-EMC/fv3atm PR#836
Refs ufs-community/ccpp-physics PR#207
Type of change
Change characteristics
How has this been tested?
Checklist