Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marine DA updates #2802

Merged
merged 12 commits into from
Aug 7, 2024
Merged

Marine DA updates #2802

merged 12 commits into from
Aug 7, 2024

Conversation

guillaumevernieres
Copy link
Contributor

@guillaumevernieres guillaumevernieres commented Jul 30, 2024 •
edited
Loading

Description

Companion PR to GDASApp/pull/1226.

waiting for global-workflow/issues/2797

Addresses a few issues described in:

Type of change

  • Bug fixes (fixes something broken)
  • New features (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

Tested on hera at c48 and c384 within the gdas.cd test and a subset of the global-workflow ci tests

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

aerorahul
aerorahul previously approved these changes Jul 30, 2024
View reviewed changes
@guillaumevernieres
Copy link
Contributor Author

I just updated the gdas.cd commit @DavidHuber-NOAA , this PR is ready to be tested.

@guillaumevernieres
Copy link
Contributor Author

... Ho wait ... global-workflow/issues/2797 needs to be sorted out before we test.

@guillaumevernieres
Copy link
Contributor Author

@DavidHuber-NOAA , the fix files have been updated on hera (updates on other hpc is in progress).

@DavidHuber-NOAA
Copy link
Contributor

Sounds good. Let's wait for #2804 to help with CI testing.

@WalterKolczynski-NOAA
Copy link
Contributor

@guillaumevernieres If you update your branch, I think we can launch CI once Hera comes back.

@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Aug 6, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Aug 6, 2024
@emcbot
Copy link

emcbot commented Aug 6, 2024

Checkout Failed on Hera: Could not perform submodule update

1 similar comment
@emcbot
Copy link

emcbot commented Aug 6, 2024

Checkout Failed on Hera: Could not perform submodule update

@emcbot emcbot added CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully labels Aug 6, 2024
@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Aug 6, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Aug 6, 2024
@guillaumevernieres
Copy link
Contributor Author

I'm going to be out of town for a few weeks @WalterKolczynski-NOAA . Any chance you could just merge develop next time it's a blocker for running the ci?

@WalterKolczynski-NOAA
Copy link
Contributor

I'm going to be out of town for a few weeks @WalterKolczynski-NOAA . Any chance you could just merge develop next time it's a blocker for running the ci?

Sure. We've had people complain in the past about modifying their branches, so we try not to do it unprompted.

@emcbot emcbot added CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Aug 7, 2024
@emcbot
Copy link

emcbot commented Aug 7, 2024

CI Passed Hera at
Built and ran in directory /scratch1/NCEPDEV/global/CI/2802


Experiment C48_ATM_caac8768 Completed 1 Cycles: *SUCCESS* at Wed Aug  7 00:03:45 UTC 2024
Experiment C48mx500_3DVarAOWCDA_caac8768 Completed 2 Cycles: *SUCCESS* at Wed Aug  7 00:27:47 UTC 2024
Experiment C48_S2SWA_gefs_caac8768 Completed 1 Cycles: *SUCCESS* at Wed Aug  7 01:35:45 UTC 2024
Experiment C48_S2SW_caac8768 Completed 1 Cycles: *SUCCESS* at Wed Aug  7 01:48:23 UTC 2024
Experiment C96_atm3DVar_caac8768 Completed 3 Cycles: *SUCCESS* at Wed Aug  7 01:59:34 UTC 2024
Experiment C96C48_hybatmDA_caac8768 Completed 3 Cycles: *SUCCESS* at Wed Aug  7 01:59:41 UTC 2024
Experiment C96_atmaerosnowDA_caac8768 Completed 3 Cycles: *SUCCESS* at Wed Aug  7 05:28:02 UTC 2024

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 7a79146 into NOAA-EMC:develop Aug 7, 2024
5 checks passed
CoryMartin-NOAA pushed a commit to CoryMartin-NOAA/global-workflow that referenced this pull request Aug 7, 2024
@guillaumevernieres @CoryMartin-NOAA
Marine DA updates (NOAA-EMC#2802)
56b940c 
Companion PR to GDASApp#1226

Addresses a few issues described in:

- GDASApp#1219
- GDASApp#1217
- GDASApp#1232
DavidHuber-NOAA added a commit to DavidHuber-NOAA/global-workflow that referenced this pull request Aug 9, 2024
@DavidHuber-NOAA
Merge remote-tracking branch 'origin/develop' into fix/c768_hera
638a588 
* origin/develop:
  Stage atmospheric backgrounds and UFS cubed-sphere history files (NOAA-EMC#2792)
  Check that a PR driver is still running before trying to kill it (NOAA-EMC#2799)
  Feature/get arch adds an empty archive job to GEFS system (NOAA-EMC#2772)
  Marine DA updates (NOAA-EMC#2802)
  Revert MSU FIX_DIRs back to glopara (NOAA-EMC#2811)
  Bugfix for updating label states in Jenkins (NOAA-EMC#2808)
  Clean-up temporary rundirs - take 2. (NOAA-EMC#2753)
  Change land surface for HR4 (NOAA-EMC#2787)
  Run METplus serially and correct the name of prod tasks (NOAA-EMC#2804)
  Update Java Agent launching script for Jenkins connections (NOAA-EMC#2762)
  Fix erroneous cdump addition (NOAA-EMC#2803)
  Update ocean post-processing triggers (NOAA-EMC#2784)
  Update the gfs_utils repository hash (NOAA-EMC#2801)
  Add fixes for metplus jobs when gfs_cyc=2 or 4 (NOAA-EMC#2791)
  Simplify resource-related variables, remove CDUMP where unneeded (NOAA-EMC#2727)
  Remove f000 from atmos rocoto tasks for replay cases (NOAA-EMC#2778)
DavidHuber-NOAA added a commit to DavidHuber-NOAA/global-workflow that referenced this pull request Aug 9, 2024
@DavidHuber-NOAA
Merge remote-tracking branch 'origin/develop' into fix/c768_hera
17efba2 
* origin/develop:
  Stage atmospheric backgrounds and UFS cubed-sphere history files (NOAA-EMC#2792)
  Check that a PR driver is still running before trying to kill it (NOAA-EMC#2799)
  Feature/get arch adds an empty archive job to GEFS system (NOAA-EMC#2772)
  Marine DA updates (NOAA-EMC#2802)
  Revert MSU FIX_DIRs back to glopara (NOAA-EMC#2811)
  Bugfix for updating label states in Jenkins (NOAA-EMC#2808)
  Clean-up temporary rundirs - take 2. (NOAA-EMC#2753)
  Change land surface for HR4 (NOAA-EMC#2787)
  Run METplus serially and correct the name of prod tasks (NOAA-EMC#2804)
  Update Java Agent launching script for Jenkins connections (NOAA-EMC#2762)
  Fix erroneous cdump addition (NOAA-EMC#2803)
  Update ocean post-processing triggers (NOAA-EMC#2784)
  Update the gfs_utils repository hash (NOAA-EMC#2801)
  Add fixes for metplus jobs when gfs_cyc=2 or 4 (NOAA-EMC#2791)
  Simplify resource-related variables, remove CDUMP where unneeded (NOAA-EMC#2727)
  Remove f000 from atmos rocoto tasks for replay cases (NOAA-EMC#2778)
@guillaumevernieres guillaumevernieres deleted the feature/diagb-filt-diff branch October 3, 2024 17:27
@guillaumevernieres guillaumevernieres restored the feature/diagb-filt-diff branch October 3, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aerorahul aerorahul aerorahul left review comments

@DavidHuber-NOAA DavidHuber-NOAA DavidHuber-NOAA left review comments

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA left review comments

@CatherineThomas-NOAA CatherineThomas-NOAA Awaiting requested review from CatherineThomas-NOAA

@AndrewEichmann-NOAA AndrewEichmann-NOAA Awaiting requested review from AndrewEichmann-NOAA AndrewEichmann-NOAA is a code owner

Assignees
No one assigned
Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@guillaumevernieres @DavidHuber-NOAA @WalterKolczynski-NOAA @emcbot @aerorahul