Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gaea C5 to CI #2814

Merged

Conversation

AnilKumar-NOAA
Copy link
Contributor

@AnilKumar-NOAA AnilKumar-NOAA commented Aug 7, 2024

Description

Adds gaea as a recognized machine in the CI system.

Type of change

  • New CI test for Gaea C5 system

Change characteristics

  • Is this a breaking change (a change in existing functionality)? YES/NO
  • Does this change require a documentation update? YES/NO
  • Does this change require an update to any of the following submodules? YES/NO (If YES, please add a link to any PRs that are pending.)
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

Copy link
Collaborator

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AnilKumar-NOAA
Copy link
Contributor Author

@WalterKolczynski-NOAA - Please check this PR for merge. Terry is the one reviewer and need your approval for final merge. Thanks

@WalterKolczynski-NOAA
Copy link
Contributor

Title and description both say Jenkinsfile, but I see no Jenkinsfile changes.

@AnilKumar-NOAA
Copy link
Contributor Author

Initially, we made changes to the Jenkinsfile, adding Gaea in several places. However, Terry later updated the Jenkinsfile himself, incorporating the Gaea additions (nodename and custom_workspace) and pushed those changes to my repo, which is why they're not reflected in this PR.

@WalterKolczynski-NOAA WalterKolczynski-NOAA changed the title Add Gaea C5 to Jenkinsfile and CI testing Add Gaea C5 to CI Aug 13, 2024
@WalterKolczynski-NOAA
Copy link
Contributor

@AnilKumar-NOAA I've updated them this time. Next time, please update them yourself to be consistent with what the PR is actually doing.

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit f2aee0a into NOAA-EMC:develop Aug 13, 2024
5 checks passed
DavidHuber-NOAA added a commit to DavidHuber-NOAA/global-workflow that referenced this pull request Aug 13, 2024
…e_rocoto

* origin/develop:
  Jenkins Pipeline Updates (NOAA-EMC#2815)
  Add Gaea C5 to CI (NOAA-EMC#2814)
  Add support for forecast-only runs on AWS (NOAA-EMC#2711)
  Add fixes to products for when REPLAY IC's are used  (NOAA-EMC#2755)
  Add capability to run forecast in segments (NOAA-EMC#2795)
CoryMartin-NOAA pushed a commit to CoryMartin-NOAA/global-workflow that referenced this pull request Aug 13, 2024
CI Testing and Jenkinsfile for Gaea C5
@AnilKumar-NOAA AnilKumar-NOAA deleted the upstream/features branch August 23, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants