Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycling on native grid and create JEDI-based analysis calc job #2949

Draft
wants to merge 57 commits into
base: develop
Choose a base branch
from

Conversation

DavidNew-NOAA
Copy link
Contributor

@DavidNew-NOAA DavidNew-NOAA commented Sep 23, 2024

Description

This PR does three things:

  1. It makes JEDI write the variational and ensemble analysis increments on the native cubed-sphere grid using the new FMS non-restart IO capability to be added to FV3-JEDI in #1251.
  2. It makes UFS read those increments on the native cubed sphere.
  3. It creates a new job, analcalc_fv3jedi, that computes the diagnostic atmospheric analyses when JEDI is being used. The GSI analcalc job is renamed analcalc_gsi.

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? YES
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES
    • EMC verif-global
    • GDAS #1293
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

Cycled test on Hera

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • I have made corresponding changes to the system documentation if necessary

jobs/JGLOBAL_ATM_CALC_ANALYSIS Fixed Show fixed Hide fixed
jobs/JGLOBAL_ATM_CALC_ANALYSIS Fixed Show fixed Hide fixed
jobs/JGLOBAL_ATM_CALC_ANALYSIS Fixed Show fixed Hide fixed
parm/config/gfs/config.calcanl Fixed Show fixed Hide fixed
ush/forecast_postdet.sh Fixed Show fixed Hide fixed
# Set variables used in the script
##############################################

GDATE=$(date --utc +%Y%m%d%H -d "${PDY} ${cyc} - ${assim_freq} hours")

Check notice

Code scanning / shellcheck

Possible misspelling: PDY may not be assigned. Did you mean gPDY? Note

Possible misspelling: PDY may not be assigned. Did you mean gPDY?
export JEDIEXE=${EXECgfs}/fv3jedi_calcanl.x

if [[ ${DOHYBVAR} = "YES" ]]; then
export CASE_ANL=${CASE_ENS}

Check notice

Code scanning / shellcheck

Possible misspelling: CASE_ENS may not be assigned. Did you mean CASE_ANL? Note

Possible misspelling: CASE_ENS may not be assigned. Did you mean CASE_ANL?
jobs/rocoto/analcalc_fv3jedi.sh Fixed Show fixed Hide fixed
jobs/rocoto/analcalc_fv3jedi.sh Fixed Show fixed Hide fixed
jobs/rocoto/analcalc_fv3jedi.sh Fixed Show fixed Hide fixed
jobs/rocoto/analcalc_fv3jedi.sh Fixed Show fixed Hide fixed
jobs/rocoto/analcalc_gsi.sh Fixed Show fixed Hide fixed
parm/config/gfs/config.analcalc_gsi Fixed Show fixed Hide fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants