Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make wxflow links static instead of from link_workflow #3008

Merged
merged 6 commits into from
Oct 31, 2024
Merged

Make wxflow links static instead of from link_workflow #3008

merged 6 commits into from
Oct 31, 2024

Conversation

WalterKolczynski-NOAA
Copy link
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA commented Oct 16, 2024 •
edited
Loading

Description

Commits symlinks to the repo for wxflow instead of relying on link_workflow to create them. This will allow testing in the ci or workflow directory without needing to run an otherwise unnecessary link_workflow first.

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • I have made corresponding changes to the system documentation if necessary

@WalterKolczynski-NOAA
Make wxflow links static instead of from link_workflow
639b7c8 
Commits symlinks to the repo for wxflow instead of relying on
link_workflow to create them. This will allow testing with the
ci or workflow directory without needing to run an otherwise
unnecessary link_workflow first.
@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Oct 16, 2024
@WalterKolczynski-NOAA WalterKolczynski-NOAA removed the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Oct 16, 2024
@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Oct 16, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera labels Oct 16, 2024
aerorahul
aerorahul approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emcbot emcbot added CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Oct 16, 2024
@emcbot
Copy link

emcbot commented Oct 16, 2024

Experiment C96_S2SWA_gefs_replay_ics FAILED on Hera in Build# 1 in
/scratch1/NCEPDEV/global/CI/3008/RUNTESTS/EXPDIR/C96_S2SWA_gefs_replay_ics_0a27fed2

@WalterKolczynski-NOAA
Copy link
Contributor Author

Failed because the fix for the gefs extractvars dependency is in #2928

@emcbot emcbot added CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Oct 17, 2024
@emcbot
Copy link

emcbot commented Oct 17, 2024

CI Failed on Hera in Build# 1
Built and ran in directory /scratch1/NCEPDEV/global/CI/3008


Experiment C96_S2SWA_gefs_replay_ics_0a27fed2 Terminated with 0 tasks failed and 0 dead at Wed Oct 16 21:59:18 UTC 2024
Experiment C96_S2SWA_gefs_replay_ics_0a27fed2 Terminated: *STALLED*
Experiment C48_ATM_0a27fed2 Completed 1 Cycles: *SUCCESS* at Wed Oct 16 22:29:34 UTC 2024
Experiment C48mx500_3DVarAOWCDA_0a27fed2 Completed 2 Cycles: *SUCCESS* at Wed Oct 16 22:29:34 UTC 2024
Experiment C96_atm3DVar_0a27fed2 Completed 3 Cycles: *SUCCESS* at Wed Oct 16 23:42:34 UTC 2024
Experiment C96C48_hybatmDA_0a27fed2 Completed 3 Cycles: *SUCCESS* at Wed Oct 16 23:42:56 UTC 2024
Experiment C48_S2SWA_gefs_0a27fed2 Completed 1 Cycles: *SUCCESS* at Wed Oct 16 23:49:29 UTC 2024
Experiment C48_S2SW_0a27fed2 Completed 1 Cycles: *SUCCESS* at Thu Oct 17 00:06:51 UTC 2024
Experiment C96C48_ufs_hybatmDA_0a27fed2 Completed 3 Cycles: *SUCCESS* at Thu Oct 17 00:13:03 UTC 2024
Experiment C96C48_hybatmaerosnowDA_0a27fed2 Completed 3 Cycles: *SUCCESS* at Thu Oct 17 00:43:51 UTC 2024

@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Oct 22, 2024
KateFriedman-NOAA
KateFriedman-NOAA approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @WalterKolczynski-NOAA !

@WalterKolczynski-NOAA WalterKolczynski-NOAA removed the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Oct 22, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Oct 22, 2024
@TerrenceMcGuinness-NOAA
Copy link
Collaborator

Jenkins controller was down yesterday. Clearing the Running label. Connection to the controller has been re-established for Hera. CI can restart for Hera now.

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA removed the CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress label Oct 23, 2024
@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress labels Oct 29, 2024
@DavidHuber-NOAA DavidHuber-NOAA added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Oct 30, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Oct 30, 2024
@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules labels Oct 31, 2024
@emcbot emcbot added CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Oct 31, 2024
@emcbot
Copy link

emcbot commented Oct 31, 2024

CI Passed on Hera in Build# 1
Built and ran in directory /scratch1/NCEPDEV/global/CI/3008


Experiment C96_S2SWA_gefs_replay_ics_9d26cb54 Completed 1 Cycles: *SUCCESS* at Wed Oct 30 16:52:48 UTC 2024
Experiment C48mx500_3DVarAOWCDA_9d26cb54 Completed 2 Cycles: *SUCCESS* at Wed Oct 30 17:05:13 UTC 2024
Experiment C48_ATM_9d26cb54 Completed 2 Cycles: *SUCCESS* at Wed Oct 30 17:05:13 UTC 2024
Experiment C48_S2SW_9d26cb54 Completed 2 Cycles: *SUCCESS* at Wed Oct 30 20:05:19 UTC 2024
Experiment C48_S2SWA_gefs_9d26cb54 Completed 1 Cycles: *SUCCESS* at Wed Oct 30 21:44:19 UTC 2024
Experiment C96_atm3DVar_9d26cb54 Completed 3 Cycles: *SUCCESS* at Thu Oct 31 03:51:51 UTC 2024
Experiment C96C48_hybatmDA_9d26cb54 Completed 3 Cycles: *SUCCESS* at Thu Oct 31 03:51:54 UTC 2024
Experiment C96C48_hybatmaerosnowDA_9d26cb54 Completed 3 Cycles: *SUCCESS* at Thu Oct 31 03:51:57 UTC 2024
Experiment C96C48_ufs_hybatmDA_9d26cb54 Completed 3 Cycles: *SUCCESS* at Thu Oct 31 07:07:47 UTC 2024

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 1cc4078 into NOAA-EMC:develop Oct 31, 2024
10 of 11 checks passed
@WalterKolczynski-NOAA WalterKolczynski-NOAA deleted the feature/move_wxflow branch October 31, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidHuber-NOAA DavidHuber-NOAA DavidHuber-NOAA approved these changes

@KateFriedman-NOAA KateFriedman-NOAA KateFriedman-NOAA approved these changes

@aerorahul aerorahul aerorahul approved these changes

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA Awaiting requested review from TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA is a code owner

Assignees
No one assigned
Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@WalterKolczynski-NOAA @emcbot @TerrenceMcGuinness-NOAA @aerorahul @KateFriedman-NOAA @DavidHuber-NOAA