fix angle rotation bug #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theresa-morrison
pushed a commit
that referenced
this pull request
May 15, 2024
* update cobalt ci answers
theresa-morrison
pushed a commit
to theresa-morrison/CEFI-regional-MOM6
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes existing python script by having each segment make its own copy of the hgrid dataset before doing any units conversion.
The requirement to convert from
degreestoradiansis primarily a concern with theNWA12domain; in other domains, theangleshould be already in radians. Therefore, this PR includes a change to assume by default that theangleis inradians. If theangle_dxvariable in thehgriddataset has a units attribute ofdegrees, it will automatically be converted toradians.