fix diag_send_complete loops and add get_file_ids #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uramirez8707
requested changes
Nov 13, 2023
diag_manager/fms_diag_object.F90
Outdated
| cycle | ||
| endif | ||
| ! Check if buffer alloc'd | ||
| has_input_buff: if (diag_field%has_input_data_buffer()) then |
There was a problem hiding this comment.
I think this if statement can be moved to outside the file loop.
allocate_diag_field_output_buffers and fms_diag_do_reduction are looping through the number of buffers for the field. The number of buffers for the field is the same as the number of files the field is in, so i think we will be doing the reductions twice here.
diag_manager/fms_diag_object.F90
Outdated
|
|
||
| call this%fms_diag_do_io() | ||
| " -"//trim(error_string))) | ||
| endif has_input_buff |
There was a problem hiding this comment.
Can we add an else here and error out with a message saying that math_needs_to_be_done is true, but there is no input buffer?
uramirez8707
approved these changes
Nov 15, 2023
rem1776
added a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
added a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
added a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
added a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
added a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
added a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
added a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
moves the loops around in diag_send_complete so that it goes through the fields, and then the files the field is in.
I've had this as part of the average updates but figured it would better to put it in separately.
Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.
Checklist:
make distcheckpasses