Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data yaml updates #1419

Merged
merged 8 commits into from
Dec 7, 2023
Merged

Data yaml updates #1419

merged 8 commits into from
Dec 7, 2023

Conversation

uramirez8707
Copy link
Contributor

@uramirez8707 uramirez8707 commented Nov 27, 2023 •
edited
Loading

Description

  1. Crashes if users have both versions of the data_table present and adds a test for this
  2. Modifies unit tests after this change
  3. Restructures the test scripts to be a bit more organized
  4. Adds error checking after reading each key of the data table yaml

Fixes #1420

How Has This Been Tested?
CI

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@rem1776 rem1776 merged commit 51af7e1 into NOAA-GFDL:main Dec 7, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rem1776 rem1776 rem1776 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data_table yaml error checking
2 participants
@uramirez8707 @rem1776