Modern_diag_manger:: Use the correct date when prepending the date #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensonr
reviewed
Jun 3, 2024
Comment on lines
+1016
to
+1017
| if (this%start_time .ne. diag_init_time) then | ||
| !> If the this%start_time is not equal to the diag_init_time from the diag_table |
There was a problem hiding this comment.
I only see a test where the date is prepended correctly. Is there a way to force this scenario to ensure it is caught?
There was a problem hiding this comment.
The second test in test_prepend_date.sh should catch this.
…ables in the file
bensonr
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the correct date when prepending the date
Fixes #1539
How Has This Been Tested?
CI, including new tests
Checklist:
make distcheckpasses