Create structures for list arrays and Add OpenACC data transfer directives #249
Conversation
tools/libfrencutils/create_xgrid.c
Outdated
| ++nxgrid; | ||
| if(nxgrid > MAXXGRID) error_handler("nxgrid is greater than MAXXGRID, increase MAXXGRID"); | ||
| } | ||
| if(xarea/min_area > AREA_RATIO_THRESH ) { |
There was a problem hiding this comment.
Which editor or IDE are you using and is it it able to use the file FRE-NCTools/.editorconfig ? (PS Emacs and VSCode should be able to use it) I am not sure, but either :
a) your editor may be breaking the indentation of some of these lines.
b) we may have to upgrade file .editorconfig
c) This file (and a few others) was never formatted post the intro of .editorconfig in the project.
PS If you do decide to apply whole file reformatting, we may not be able to do so for the "usage" comment near
the top.
PPS This also applies to other files (or functions) that were worked on.
There was a problem hiding this comment.
Why am I having these spacing issues all of a sudden? Is this .editorconfig file new?
There was a problem hiding this comment.
I did download the editorconfig plugin for emacs but these mysterious differences are still showing up
There was a problem hiding this comment.
@mlee03
OK I'll accept it. Relating to this we've had a historical and informal modus operandi you might want to be aware of. With the intent of helping the reviewer, usually we have not reformatted entire files, but only those functions that were needed to be modified to fix the bug or add the enhancement. This ultimately stemmed from the fact that we have limited unit tests, and so reviewers must look carefully at those lines that are truly modified or changed; looking at other lines is extra work and effort that detracts from checking correctness. If it was desirable to reformat entire files just to upgrade the format, this was done in a separate push and possibly with a different PR.
mlee03
force-pushed
the
struct_outlists
branch
from
7616ce2
to
ccede60
Compare
|
@ngs333, ready for merging with your approval. |
| void malloc_minmaxavg_lists(const int n, | ||
| double **lon_min_list, double **lon_max_list, double **lat_min_list, double **lat_max_list, | ||
| int **n_list, double **lon_avg, double **lon_list, double **lat_list) | ||
| void malloc_minmaxavg_lists(const int n, Minmaxavg_lists *minmaxavg_lists) | ||
| { |
There was a problem hiding this comment.
OK This new version could work.
tools/libfrencutils/create_xgrid.c
Outdated
| ++nxgrid; | ||
| if(nxgrid > MAXXGRID) error_handler("nxgrid is greater than MAXXGRID, increase MAXXGRID"); | ||
| } | ||
| if(xarea/min_area > AREA_RATIO_THRESH ) { |
There was a problem hiding this comment.
@mlee03
OK I'll accept it. Relating to this we've had a historical and informal modus operandi you might want to be aware of. With the intent of helping the reviewer, usually we have not reformatted entire files, but only those functions that were needed to be modified to fix the bug or add the enhancement. This ultimately stemmed from the fact that we have limited unit tests, and so reviewers must look carefully at those lines that are truly modified or changed; looking at other lines is extra work and effort that detracts from checking correctness. If it was desirable to reformat entire files just to upgrade the format, this was done in a separate push and possibly with a different PR.
In this PR,
Minmaxavglistshas been declared to hold all "list" arrays pertaining to the output gridget_minmaxavg_listshas been created. This function computes values for the "list" arrays in structure MinmaxavglistsOpenACCdirectives to transfer data to/from the device has been added.