create do_great_circle, do_create_xgrid_order1, and do_create_xgrid_order2
#255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is not ready. CI passes and the code compiles when generating the parallelized versions of fregrid, etc. But the code does not compile with nvc for a very good reason: an argument was not passed into a function. It's strange that nvc is the only compiler that caught this mistake? |
|
PR is ready |
|
@ngs333 ready for your review. Let me know if you want to meet up to discuss this PR for clarifications/problems, etc :) |
ngs333
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR,
do_great_clrcle,do_create_xgrid_order1, anddo_create_xgrid_order2functions have been created and is called in setup_conserve_interp. Creation of these function cleans up the non-read portion of setup_conserve_interp and will make the process of adding OpenACC directives easier. Future plans to combinedo_create_xgrid_order1anddo_create_xgrid_order2will be considered.Remapping of scalar data from cubed-sphere to latlon grid with conserve_interp1 and conserve_interp2 methods have been tested on CPUs.