Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for fregrid to properly sets NC4 compression #258

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Fix for fregrid to properly sets NC4 compression #258

merged 3 commits into from
Dec 7, 2023

Conversation

ceblanton
Copy link
Contributor

Also, comment-out the print statements as they are not useful to the user.

resolves #257

#257 fix mpp_set_deflation to properly set NC4 compression settings
b1040ec 
Also, comment-out the print statements as they are not useful to the user.
@ngs333 ngs333 added the bug label Nov 22, 2023
ngs333
ngs333 reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@ngs333 ngs333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

tools/libfrencutils/mpp_io.c Outdated Show resolved Hide resolved
tools/libfrencutils/mpp_io.c Show resolved Hide resolved
tools/libfrencutils/mpp_io.c Outdated Show resolved Hide resolved
Chris Blanton added 2 commits December 5, 2023 16:43
#258 added inline note explaining the two different variable IDs
34c282e 
that are a bit confusing. The MPP variable id is merely a counter,
and the netCDF variable ID stored in the fldid (field id) data structure
is the right one to use for native netCDF methods.
#258 Remove commented print debug statements
6d27d97
@ceblanton ceblanton requested a review from ngs333 December 5, 2023 21:52
@ceblanton
Copy link
Contributor Author

An example of the updates working properly could be done with:

tar -xf /archive/Raphael.Dussin/FMS2019.01.03_devgfdl_20230608/CM4_piControl_c192_OM4p125_v8/gfdl.ncrc5-intel22-prod-openmp/history/01800101.nc.tar ./01800101.ocean_annual.nc
tar -xf /archive/Raphael.Dussin/FMS2019.01.03_devgfdl_20230608/CM4_piControl_c192_OM4p125_v8/gfdl.ncrc5-intel22-prod-openmp/history/01800101.nc.tar ./01800101.ocean_static.nc
set vars = `list_ncvars.csh -st234 01800101.ocean_annual.nc | xargs | tr ' ' ,`
fregrid --standard_dimension --input_mosaic ocean_mosaic.nc --input_file 01800101.ocean_annual.nc --interp_method conserve_order1 --remap_file remap_file_native_to_1x1.nc --nlon 360 --nlat 180 --scalar_field $vars --output_file out.nc

@ngs333 ngs333 merged commit a2da1b6 into master Dec 7, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngs333 ngs333 ngs333 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fregrid fails with "Error in setting deflation level" when using Netcdf-4
2 participants
@ceblanton @ngs333