Move globals.h file from fregrid to libfrenctools directory #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rem1776
requested review from
nikizadehgfdl,
bensonr,
ceblanton,
thomas-robinson and
rem1776
ceblanton
approved these changes
Apr 3, 2024
rem1776
reviewed
Apr 8, 2024
There was a problem hiding this comment.
I think this file is also renamed in the other pr. Is there a reason we wanted to do this separately?
If not we can probably close this one and just use the other PR. I think it makes more sense to have the filename change alongside the changes done to the build files.
|
PR #282 depends on this PR. I opened it as a separate PR in case there were any objections to relocating the file. Assuming there are no objections, I'll close this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
globals.hheader file contains all macro and struct definitions that can be used universally among all tools in FRE-NCTools. Thus in this PR,globals.hhas been moved to thelibfrencutilsdirectory to better reflect the file's purpose.Related to Issue #280