#2 - fregrid_acc: create functions read_remap_file and copy_interp_to_device #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
March 27, 2024 12:17
rem1776
requested review from
nikizadehgfdl,
bensonr,
ceblanton,
thomas-robinson and
rem1776
bensonr
approved these changes
Apr 24, 2024
mlee03
changed the title
mlee03
changed the title
|
closing, a larger PR will contain this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR,
setup_conserve_interpinvolves reading in an existing remap file and storing the read-in data to an interp struct. This portion has been relocated to a newly created functionread_remap_file.copy_interp_to_devicehas been defined in a newly created fregrid_utils_acc.c/h file. This function transfers the interp struct to the device.Call to
read_remap_filefollowed by a call tocopy_interp_to_devicecopies the data from the remap file to the device.The accompanying unit test checks to ensure data has been copied in correctly by checking the answers on the device and on the host for both conserve_order1 and conserve_order2 interpolation methods.